From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946672AbcBRQ5U (ORCPT ); Thu, 18 Feb 2016 11:57:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43864 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425536AbcBRQ5T (ORCPT ); Thu, 18 Feb 2016 11:57:19 -0500 Subject: Re: [PATCH] IB/rxe: fix compare_const_fl.cocci warnings To: Julia Lawall , Kamal Heib References: Cc: kbuild-all@01.org, Amir Vadai , Haggai Eran , Sean Hefty , Hal Rosenstock , Greg Kroah-Hartman , linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Doug Ledford Message-ID: <56C5F7DB.1070009@redhat.com> Date: Thu, 18 Feb 2016 11:56:59 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="m7GppCRgEDWUxkSxQqRaOWJrRrmOH0vDw" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --m7GppCRgEDWUxkSxQqRaOWJrRrmOH0vDw Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/18/2016 8:06 AM, Julia Lawall wrote: > Move constants to the right of binary operators. >=20 > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci >=20 > CC: Kamal Heib > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- >=20 > The constants on the right look a bit nicer. Another possibility would= be > !!. >=20 > tree: https://github.com/dledford/linux.git rxe-v2 > head: bc91f3e63df667e8da8894a51149a2fc9acf0e71 > commit: 30e5584cf453cd90bbcd3ebb5f3e774c0195dd83 [30/31] IB/rxe: Add > Soft-RoCE to kbuild and makefiles >=20 > rxe_mr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > --- a/drivers/staging/rdma/rxe/rxe_mr.c > +++ b/drivers/staging/rdma/rxe/rxe_mr.c > @@ -43,8 +43,8 @@ static u8 rxe_get_key(void) >=20 > key =3D key << 1; >=20 > - key |=3D (0 !=3D (key & 0x100)) ^ (0 !=3D (key & 0x10)) > - ^ (0 !=3D (key & 0x80)) ^ (0 !=3D (key & 0x40)); > + key |=3D ((key & 0x100) !=3D 0) ^ ((key & 0x10) !=3D 0) > + ^ ((key & 0x80) !=3D 0) ^ ((key & 0x40) !=3D 0); >=20 > key &=3D 0xff; >=20 Thanks, applied to my rxe-v2 branch. --m7GppCRgEDWUxkSxQqRaOWJrRrmOH0vDw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJWxffbAAoJELgmozMOVy/d7qIP/1lAk68haf/k4VHmSOTR4SjA HI/W4QMXj2wx/Uwza4f8lgQfInPTGb51Zh0nMQ1uDYqxDzEHbVnZtTHt0U5XCGwB YhLJraahVbwhuhR1UlbAO3T17YTnIx/xyGTqd5rFoA7f4tiDlYGzJxJR7SKPRdAe FKwQbRhLHN2RmhtlwqXgyQR2vxbc0WChqcP2Cbj2qgH8hZFdesw41MkG7GH0eKzy C1yzkkj4fNj1/RLD6GfeuETzM+UJ9gE04nwN/i7hLR5yzF1p0ZSNMzOUtbW3PP2h zYWx+WnARzlExFrL7wRf6wWft2/7pTNb3PkhPjgBqsA/OVT+JOCJAlpqFE+5AIjo LQcKB/yRUG9PhPWXhcMZVt23+SBMDzQ+yp2dkT15SbcthR5irmacOkxMiEsxset5 wF0F0RdFeeV4rknKC2B8/Xm52uB99gOGiASibLXtmMYYgwhokB3ROu6mFs7YavF1 LZwwDwQMSyntfgBwKLfX48xsmrLyNGrKwol0jNWQuDU1i4PYIM3MV6x1CgKaVV2J SyJpFCaLi4BF0KdCFBLC4mZbMsctl54YahiTHZ+7zKV8bRw/tK/INpsVBHYco7bO XzLRTlgaYq15L9q1dZVP73jdg/ZIatofH8l1pLYoJPfN2XOYiFDDT/MkEkBoJuNb RJcKqHJ5ZNtW/hs99J1S =9YXM -----END PGP SIGNATURE----- --m7GppCRgEDWUxkSxQqRaOWJrRrmOH0vDw--