From: Doug Ledford <dledford@redhat.com>
To: Insu Yun <wuninsu@gmail.com>,
faisal.latif@intel.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, taesoo@gatech.edu,
yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu
Subject: Re: [PATCH] nes: handling failed allocation when creating workqueue
Date: Thu, 18 Feb 2016 12:45:43 -0500 [thread overview]
Message-ID: <56C60347.7040506@redhat.com> (raw)
In-Reply-To: <20160218045905.GF30450@leon.nu>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
On 2/17/2016 11:59 PM, Leon Romanovsky wrote:
> Please see my minor comments below.
> Reviewed-by: Leon Romanovsky <leon@leon.nu>
>
> On Wed, Feb 17, 2016 at 01:06:33PM -0500, Insu Yun wrote:
>> Since create_singlethread_workqueue uses kzalloc internally,
>> it can be failed in memory pressure, so need to handle it.
>
> s/can be failed/can fail/
>
>>
>> Signed-off-by: Insu Yun <wuninsu@gmail.com>
>> ---
>> drivers/infiniband/hw/nes/nes_cm.c | 13 ++++++++++++-
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
>> index cb9f0f2..23afad6 100644
>> --- a/drivers/infiniband/hw/nes/nes_cm.c
>> +++ b/drivers/infiniband/hw/nes/nes_cm.c
>> @@ -2833,7 +2833,7 @@ static struct nes_cm_core *nes_cm_alloc_core(void)
>> /* alloc top level core control structure */
>> cm_core = kzalloc(sizeof(*cm_core), GFP_KERNEL);
>> if (!cm_core)
>> - return NULL;
>> + goto enomem_3;
>
> IMHO, there is no need to define goto label for one return.
I made the touchups Leon suggested, and a touchup of my own, but it is
now applied, thanks.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-02-18 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:06 [PATCH] nes: handling failed allocation when creating workqueue Insu Yun
2016-02-18 4:59 ` Leon Romanovsky
2016-02-18 17:45 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C60347.7040506@redhat.com \
--to=dledford@redhat.com \
--cc=changwoo@gatech.edu \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=insu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=taesoo@gatech.edu \
--cc=wuninsu@gmail.com \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox