From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1946073AbcBRSD4 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Feb 2016 13:03:56 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:34108 "EHLO
	mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1161752AbcBRSDx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Feb 2016 13:03:53 -0500
Subject: Re: [PATCH v2 07/14] KVM: x86: remove unnecessary uses of PIT state
 lock
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        linux-kernel@vger.kernel.org
References: <1455736496-374-1-git-send-email-rkrcmar@redhat.com>
 <1455736496-374-8-git-send-email-rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, Yuki Shibuya <shibuya.yk@ncos.nec.co.jp>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56C60785.1080100@redhat.com>
Date: Thu, 18 Feb 2016 19:03:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <1455736496-374-8-git-send-email-rkrcmar@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 17/02/2016 20:14, Radim Krčmář wrote:
> +	/* All members before "struct mutex lock" are protected by the lock. */

... except reinject, according to the commit message. :)

Paolo

>  	struct kvm_kpit_channel_state channels[3];
>  	u32 flags;
>  	bool is_periodic;
>  	s64 period; 				/* unit: ns */
>  	struct hrtimer timer;
> -	atomic_t pending;			/* accumulated triggered timers */
>  	bool reinject;
> -	struct kvm *kvm;
>  	u32    speaker_data_on;
> +