From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426720AbcBRSLH (ORCPT ); Thu, 18 Feb 2016 13:11:07 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33814 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030349AbcBRSLF (ORCPT ); Thu, 18 Feb 2016 13:11:05 -0500 Subject: Re: [PATCH v2 00/14] KVM: x86: change PIT discard policy and untangle related code To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org References: <1455736496-374-1-git-send-email-rkrcmar@redhat.com> Cc: kvm@vger.kernel.org, Yuki Shibuya From: Paolo Bonzini Message-ID: <56C60935.6020909@redhat.com> Date: Thu, 18 Feb 2016 19:11:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455736496-374-1-git-send-email-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/2016 20:14, Radim Krčmář wrote: > v2 > - Different ordering; the important fix is first, which makes it easier > to backport as improvements of [1/14] have complex dependencies. > - Correct choice of atomics in [2/14]. > - Explicit SMP barriers for lockless updates in [3/14]. > - Protection against userspace races in kvm_vm_ioctl_reinject, [8/14]. > - New code churn. (I tried to annotate locking, which required me to > really look at the code and I couldn't leave it alone at that point; > sorry.) > > This series only works with the discard policy, do you want to "fix" NMI > in the delay policy as well? > (NMI delivery is still is going to be wrong by any standard, but will > make some sense, at the cost of ugly code: we would always inject NMI > when the timer fires and suppress NMI injection on EOI reinject.) > > Anatomy of the series: > [1/14] fixes legacy NMI watchdog under discard policy. > [2-7/14] prepare for optimization of the discard policy. > [8/14] optimizes discard policy by removing notifiers. > [9-14/14] slightly improve related code. > > I'm ok with dropping patches [2-14/14]. > > v1: http://www.spinics.net/lists/kvm/msg127017.html > > Radim Krčmář (14): > KVM: x86: change PIT discard tick policy > KVM: x86: simplify atomics in kvm_pit_ack_irq > KVM: x86: add kvm_pit_reset_reinject > KVM: x86: use atomic_t instead of pit.inject_lock > KVM: x86: tone down WARN_ON pit.state_lock > KVM: x86: pass struct kvm_pit instead of kvm in PIT > KVM: x86: remove unnecessary uses of PIT state lock > KVM: x86: remove notifiers from PIT discard policy > KVM: x86: refactor kvm_create_pit > KVM: x86: refactor kvm_free_pit > KVM: x86: remove pit and kvm from kvm_kpit_state > KVM: x86: remove pointless dereference of PIT > KVM: x86: don't assume layout of kvm_kpit_state > KVM: x86: move PIT timer function initialization > > arch/x86/kvm/i8254.c | 318 +++++++++++++++++++++++---------------------------- > arch/x86/kvm/i8254.h | 15 +-- > arch/x86/kvm/x86.c | 52 ++++++--- > 3 files changed, 187 insertions(+), 198 deletions(-) > Patches 1 and 9-14: Reviewed-by: Paolo Bonzini Thanks! Paolo