From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426919AbcBRXzW (ORCPT ); Thu, 18 Feb 2016 18:55:22 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:10758 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426241AbcBRXzS (ORCPT ); Thu, 18 Feb 2016 18:55:18 -0500 X-AuditID: cbfec7f5-f79b16d000005389-12-56c659e3e514 Subject: Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load To: Marek Szyprowski , Viresh Kumar References: <1455692128-28504-1-git-send-email-k.kozlowski@samsung.com> <1455692128-28504-4-git-send-email-k.kozlowski@samsung.com> <56C522A9.8070800@samsung.com> <20160218023622.GA2610@vireshk-i7> <56C54B9B.7030105@samsung.com> <56C595F7.1080406@samsung.com> Cc: Anand Moon , Kukjin Kim , Lukasz Majewski , linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Linux PM list , Zhang Rui , Eduardo Valentin , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas From: Krzysztof Kozlowski Message-id: <56C659DE.8010402@samsung.com> Date: Fri, 19 Feb 2016 08:55:10 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <56C595F7.1080406@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4Vd3HkcfCDH4/kLfYOGM9q8X8K9dY Ld68XcNk8fqFoUX/49fMFm8ebma02PQYKH551xw2i8+9RxgtZpzfx2SxbuMtdou1R+6yWzx5 2MdmsfGrhwOfx85Zd9k9Fu95yeSxaVUnm8eda3vYPDYvqffY0g8U79uyitHj8ya5AI4oLpuU 1JzMstQifbsErowz3ZOYCy7zV9x5adzAuJK3i5GTQ0LAROJd20EmCFtM4sK99WxdjFwcQgJL GSVW/vrLAuE8ZZR4s2kyO0iVsECAxI/9l8BsEYFIiZ5nLawQRReYJN7/agNrZxb4zizR+2My G0gVm4CxxOblS8BsXgEtiVnHtoJ1swioShybdwIsLioQIXG4s4sdokZQ4sfkeywgNqeAtsSb jyuYuxg5gIaqS0yZkgsSZhaQl9i85i3zBEaBWUg6ZiFUzUJStYCReRWjaGppckFxUnqukV5x Ym5xaV66XnJ+7iZGSAx93cG49JjVIUYBDkYlHt4KvWNhQqyJZcWVuYcYJTiYlUR4df2BQrwp iZVVqUX58UWlOanFhxilOViUxHln7nofIiSQnliSmp2aWpBaBJNl4uCUamDU+is39aHbO33W Jytlp/Ivk1XQfHpz+bOe08l/HVpe1t9bzH5w5dG0YxxfrJ6JRMSe0FhrOmvBh1jjMsP7IdOt XpzuEv7q+kCj7pxRasdbO5FFH4Jd7vBZdj9yEPrBnrDpEbOu7x6h9D2SQksm3ImLv7Rdylgo hunYreLd7FLnigX3fWifJT1diaU4I9FQi7moOBEA8Quc+50CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.02.2016 18:59, Marek Szyprowski wrote: > Hello, > > On 2016-02-18 05:42, Krzysztof Kozlowski wrote: >> On 18.02.2016 11:36, Viresh Kumar wrote: >>>> BTW, I found the issue. The order of trip points in DT: >>>> thermal_zone0/trip_point_0_hyst:5000 >>>> thermal_zone0/trip_point_0_temp:50000 >>>> thermal_zone0/trip_point_0_type:active >>>> thermal_zone0/trip_point_1_hyst:5000 >>>> thermal_zone0/trip_point_1_temp:60000 >>>> thermal_zone0/trip_point_1_type:active >>>> thermal_zone0/trip_point_2_hyst:5000 >>>> thermal_zone0/trip_point_2_temp:70000 >>>> thermal_zone0/trip_point_2_type:active >>>> thermal_zone0/trip_point_3_hyst:0 >>>> thermal_zone0/trip_point_3_temp:120000 <---- this should be last >>>> one! >>>> thermal_zone0/trip_point_3_type:critical >>>> thermal_zone0/trip_point_4_hyst:5000 >>>> thermal_zone0/trip_point_4_temp:90000 >>>> thermal_zone0/trip_point_4_type:passive >>>> thermal_zone0/trip_point_5_hyst:5000 >>>> thermal_zone0/trip_point_5_temp:110000 >>>> thermal_zone0/trip_point_5_type:passive >>>> >>>> After fixing the order in DT, the cpu cooler starts working. >>> Ahh, nice. >> Damn, not entirely. I almost fried my Odroid (it survived 130 degrees of >> C)... The TMU supports only 4 trip points, so when I added two new trip >> points and reordered them... the last two (including critical) was not >> receiving interrupts. >> >> Polling mode is needed. I'll sent some patches soon... > > Instead of polling the driver should simply use some dynamic window for > the nearest temperature ranges and reconfigure it when interrupt of occurs. Thanks for feedback, Marek! First of all the polling happens only when initial trip point for passive cooling is reached (70 degrees C). This fortunately reduces the polling overhead. Yours idea seems interesting... but driver does not support it now, does it? I can put this on TODO list, maybe someone will extend the exynos thermal driver. Best regards, Krzysztof