From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948904AbcBSAdQ (ORCPT ); Thu, 18 Feb 2016 19:33:16 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:11193 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946981AbcBSAdL (ORCPT ); Thu, 18 Feb 2016 19:33:11 -0500 X-AuditID: cbfec7f5-f79b16d000005389-ed-56c662c40814 Subject: Re: [PATCH 2/3] thermal: exynos: Use devm_regulator_get_optional() for vtmu To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1455819551-4666-1-git-send-email-javier@osg.samsung.com> <1455819551-4666-3-git-send-email-javier@osg.samsung.com> Cc: linux-arm-kernel@lists.infradead.org, Kukjin Kim , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Lukasz Majewski , Zhang Rui , Eduardo Valentin From: Krzysztof Kozlowski Message-id: <56C662BF.5080903@samsung.com> Date: Fri, 19 Feb 2016 09:33:03 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1455819551-4666-3-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xK7pHko6FGZz/w2cx/8o1Vos3b9cw Wbx+YWjR//g1s8Wbh5sZLTY9Bopf3jWHzeJz7xFGixnn9zFZPHnYx+bA5bFz1l12j8V7XjJ5 bFrVyeaxeUm9x5Z+oFDfllWMHp83yQWwR3HZpKTmZJalFunbJXBl/Ju/jL2gn73izLFP7A2M T1m7GDk5JARMJJ7NussGYYtJXLi3Hsjm4hASWMoo8WXDDUYI5ymjxJwjj5hBqoQFwiTeLljJ AmKLCIRK/Lt4G6qokVFi87UdTCAOs8BfRome9WvAqtgEjCU2L18CtoNXQEti3uHVYLtZBFQl Hm/qB4uLCkRIHO7sYoeoEZT4MfkeUC8HB6eAm8T+SZ4gJrOAnsT9i1ogFcwC8hKb17xlnsAo MAtJwyyEqllIqhYwMq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECImJrzsYlx6zOsQowMGo xMNboXcsTIg1say4MvcQowQHs5IIr64/UIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE 0hNLUrNTUwtSi2CyTBycUg2MDt0be9dOvPM1xHnn/Um3ptca82ivKdgbkdD4XDFQLn+zvfOv 0zdM+SeuXFBmMkdIYMbn8NmxESU2J95ov9DfzXxyWV/WZa0ZiZ9fKV5Q3OkWUPGxde6h2bkW tpHT4ydFra611fhWUNCfcmuiyHGpjFvsdtKnDs9j/3Vl60rWgBrHvV4bKhZYKbEUZyQaajEX FScCAPcF4I+FAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.02.2016 03:19, Javier Martinez Canillas wrote: > The Exynos TMU DT binding says that the vtmu-supply is optional but the > driver uses devm_regulator_get() that creates a dummy regulator if it's > not defined in the DT. For example the following message is in the log: > > 10060000.tmu supply vtmu not found, using dummy regulator > > Use the optional version of regulator_get() that doesn't create a dummy > regulator and instead returns a -ENODEV errno code. Since it's expected > that a regulator may not be defined and the driver will inform about it: > > exynos-tmu 10060000.tmu: Regulator node (vtmu) not found > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof