From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992578AbcBSAhL (ORCPT ); Thu, 18 Feb 2016 19:37:11 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:18386 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947867AbcBSAhI (ORCPT ); Thu, 18 Feb 2016 19:37:08 -0500 X-AuditID: cbfec7f5-f79b16d000005389-e1-56c663b02122 Subject: Re: [PATCH 3/3] thermal: exynos: Defer probe if vtmu is present but not registered To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1455819551-4666-1-git-send-email-javier@osg.samsung.com> <1455819551-4666-4-git-send-email-javier@osg.samsung.com> Cc: linux-arm-kernel@lists.infradead.org, Kukjin Kim , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Lukasz Majewski , Zhang Rui , Eduardo Valentin From: Krzysztof Kozlowski Message-id: <56C663AC.7030601@samsung.com> Date: Fri, 19 Feb 2016 09:37:00 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1455819551-4666-4-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xa7obko+FGTy6Zmkx/8o1Vos3b9cw Wbx+YWjR//g1s8Wbh5sZLTY9Bopf3jWHzeJz7xFGixnn9zFZPHnYx+bA5bFz1l12j8V7XjJ5 bFrVyeaxeUm9x5Z+oFDfllWMHp83yQWwR3HZpKTmZJalFunbJXBl/O05y1TwlbViwu3FbA2M L1i6GDk5JARMJH629jNC2GISF+6tZwOxhQSWMkpsucjbxcgFZD9llHj84z5YkbBArETvgn2s ILaIQKjEv4u3GSGKGhkl5h9cxw7iMAv8ZZToWb8GbAWbgLHE5uVLwMbyCmhJ7F24jR3EZhFQ lZj2aTJYXFQgQuJwZxc7RI2gxI/J98B6OQXcJCb9mARkcwAN1ZO4f1ELJMwsIC+xec1b5gmM ArOQdMxCqJqFpGoBI/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJCY+LqDcekxq0OMAhyM Sjy8FXrHwoRYE8uKK3MPMUpwMCuJ8Or6A4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRI ID2xJDU7NbUgtQgmy8TBKdXAmPaIX6Usx7qirkDiv7WzYcIN0Z+8plOltjKuuSw4Q549XjPW +r1x43uFjDxX0+cXX9+J5D7Xf3Tty+rlq6STlhxWCrsVtbhESl3K+3LNbjbhwI8rFG2K4us/ rAzzadi54/fFne8+fMyT32yltVRD8lWU5JU28bQsu/iLl3/+FspdMvWxy8R3SizFGYmGWsxF xYkAXTWL7oUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.02.2016 03:19, Javier Martinez Canillas wrote: > The driver doesn't check if the regulator_get_optional return value is > -EPROBE_DEFER so it will wrongly assume that the regulator couldn't be > found just because the regulator driver wasn't registered yet, i.e: > > exynos-tmu 10060000.tmu: Regulator node (vtmu) not found > > In this case the return value should be propagated to allow the driver > probe function to be deferred until the regulator driver is registered. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/thermal/samsung/exynos_tmu.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof