From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423508AbcBSDbz (ORCPT ); Thu, 18 Feb 2016 22:31:55 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33863 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030320AbcBSDbx (ORCPT ); Thu, 18 Feb 2016 22:31:53 -0500 Subject: Re: [PATCH 2/3] drm/nouveau: use post-decrement in error handling To: Rasmus Villemoes , David Airlie References: <1455561708-32390-1-git-send-email-linux@rasmusvillemoes.dk> <1455561708-32390-3-git-send-email-linux@rasmusvillemoes.dk> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Ben Skeggs Message-ID: <56C68CE7.30104@gmail.com> Date: Fri, 19 Feb 2016 13:32:55 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455561708-32390-3-git-send-email-linux@rasmusvillemoes.dk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BKT82tm3mXhE877pPM93oSnhTc1hH4IH7" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BKT82tm3mXhE877pPM93oSnhTc1hH4IH7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2016 04:41 AM, Rasmus Villemoes wrote: > We need to use post-decrement to get the dma_map_page undone also for > i=3D=3D0, and to avoid some very unpleasant behaviour if dma_map_page > failed already at i=3D=3D0. >=20 > Signed-off-by: Rasmus Villemoes Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nou= veau/nouveau_bo.c > index 78f520d05de9..e3acc35e3805 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -1520,7 +1520,7 @@ nouveau_ttm_tt_populate(struct ttm_tt *ttm) > DMA_BIDIRECTIONAL); > =20 > if (dma_mapping_error(pdev, addr)) { > - while (--i) { > + while (i--) { > dma_unmap_page(pdev, ttm_dma->dma_address[i], > PAGE_SIZE, DMA_BIDIRECTIONAL); > ttm_dma->dma_address[i] =3D 0; >=20 --BKT82tm3mXhE877pPM93oSnhTc1hH4IH7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWxoznAAoJEHYLnGJQkpH7o90P/RXmsfTwbLaKN0ChUQa07feO tmOAFCOiSFuRlodCSVmGjlCwezN4IagJz1oCPpYGqpZJ2ZbJ9cb6aFw7JMx3dYJ4 DX8/BWR6vZADgKoxOmBJkzSxtXoB0ElOut2BSepAmedN7/6/uEKyAWflfAoa0S3w Yw5AHdM/AocYrTN1mtHowo3hl1LJaptZ1j0gxYzqjTHdfDV+xKGg+6T0943ET+vz mHc68JmVyuJk0fOeOmSj/3kEJP8jlZpXOwMTpaH1MNAxEAidECWLQGuI5P4bWiqh Bz5IS0phSnRVnah2f+yNQ1ziAG/EOoXvOict+MIFt6bWk05hBVrEMnDv5Ie4M10t 0on8Q1QLryHHZS1CLFx8Z8dWcU5guUsSiQPT9n/+2jneQX3WhQHzTNLd0Vz7AsPO QZCiCwv4iR4kzPrRZvsJJHt0m/nneEd92BeXEoWZG6MbZo1JVPpsS+STNvkZLKuO KQksdOIZPHw+EPFN3tHRM57ru2PssylsTr7wu3dh1QCdbWko4nO4O52zhdGD14uU sv/mMDfVwhvhORJs2n5kmO1CsiLzGA5s8xNnu2uUyF1ELLMj0er0oaJiwzI+WS9B 12ZkwmlO+t/aquPjmkkzlbAlvPpztyo4HoSAKxY3CGZa09Sif44gGnuARBQi/hLm bbW5ausNU2ngTClynwk4 =sSvG -----END PGP SIGNATURE----- --BKT82tm3mXhE877pPM93oSnhTc1hH4IH7--