From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427534AbcBSKFt (ORCPT ); Fri, 19 Feb 2016 05:05:49 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38203 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757364AbcBSKFn (ORCPT ); Fri, 19 Feb 2016 05:05:43 -0500 Subject: Re: [PATCH] ARM64: dts: Mediatek: mt8173-evb: fix access MMC fail issue To: Eddie Huang , Kevin Hilman References: <1455861643-24307-1-git-send-email-eddie.huang@mediatek.com> Cc: Henry Chen , Chaotian Jing , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com From: Matthias Brugger Message-ID: <56C6E8F3.4020402@gmail.com> Date: Fri, 19 Feb 2016 11:05:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1455861643-24307-1-git-send-email-eddie.huang@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eddie, On 19/02/16 07:00, Eddie Huang wrote: > MT8173 E1 chip has one bug that if turn off USB power domain, vcore > power will also be off, thus cause modules using vcore power domain > fail, like MMC. The E1 chip only found on MT8173-evb board and this > board only has E1 chip, so implement this as a board specific > workaround. > > Pwrapper use vcore power, so add pwrapper using USB power domain to > keep USB power domain not to zero and disabled. > > Signed-off-by: Eddie Huang > > --- > Sascha sent similar patch before[0], but MMC support runtime-pm, > vcore power domain still be disabled after MMC and USB suspend. > This silicon bug already fix in MT8173 MP chip. > > [0]:http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/358065.html > --- > arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > index e427f04..7453a47 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > @@ -214,6 +214,9 @@ > }; > > &pwrap { > + /* Only MT8173 E1 needs USB power domain */ > + power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>; > + Applied, thanks