linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr,
	linux-kernel@vger.kernel.org,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Harish Chegondi <harish.chegondi@intel.com>,
	Michal Marek <mmarek@suse.com>,
	Nicolas Palix <nicolas.palix@imag.fr>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] scripts/coccinelle: modernize &
Date: Fri, 19 Feb 2016 13:25:05 +0100	[thread overview]
Message-ID: <56C709A1.6060004@users.sourceforge.net> (raw)
In-Reply-To: <1455750974-24339-1-git-send-email-Julia.Lawall@lip6.fr>

> & is no longer allowed in column 0, since Coccinelle 1.0.4.

This information corresponds to the support for handling of conjunctions
in the semantic patch language which was added with the software
release "Coccinelle 1.0.3".
https://systeme.lip6.fr/pipermail/cocci/2015-October/002634.html


> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member

The added space character is not in the first column of this SmPL script.

* Can it be that the additional character will be transformed according to
  special pretty-printing rules?
  https://github.com/coccinelle/coccinelle/issues/37

* Is such a change a possible workaround for open issues around
  the message "minus: parse error" (or software improvements
  which were developed in the meantime)?


>  |
>  c = E
>  |


Does the shown tweak need any further considerations?

Regards,
Markus

      parent reply	other threads:[~2016-02-19 12:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 23:16 [PATCH] scripts/coccinelle: modernize & Julia Lawall
2016-02-17 23:47 ` Nishanth Menon
2016-02-18  0:46   ` Julia Lawall
2016-02-19 13:09   ` Michal Marek
2016-02-19 12:25 ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C709A1.6060004@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Julia.Lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=harish.chegondi@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=nicolas.palix@imag.fr \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).