From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161982AbcBSMZh (ORCPT <rfc822;w@1wt.eu>);
	Fri, 19 Feb 2016 07:25:37 -0500
Received: from mout.web.de ([212.227.15.3]:62226 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932074AbcBSMZf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 19 Feb 2016 07:25:35 -0500
Subject: Re: [PATCH] scripts/coccinelle: modernize &
To: Julia Lawall <Julia.Lawall@lip6.fr>
References: <1455750974-24339-1-git-send-email-Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr,
        linux-kernel@vger.kernel.org, Gilles Muller <Gilles.Muller@lip6.fr>,
        Harish Chegondi <harish.chegondi@intel.com>,
        Michal Marek <mmarek@suse.com>, Nicolas Palix <nicolas.palix@imag.fr>,
        Nishanth Menon <nm@ti.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <56C709A1.6060004@users.sourceforge.net>
Date: Fri, 19 Feb 2016 13:25:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1455750974-24339-1-git-send-email-Julia.Lawall@lip6.fr>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:2Ciip2hubBMuTicwBD2XF733KIZ3JvCGiZvnTqp3HE/nvKsrwMl
 lErevBxRaCCV7GDXc9IBP72eyDZ59rAhT00rZ6SJaSCHNsUkH6fgsCDzKHZvDc1IyuCLulA
 oWFkDnpNgPKDbbyG3V6jhZuufj+HWRKEjBN5B5f4SDXTlPJTrmy2Ov2zkFz4XG88DV13t8y
 D4DKSEgFb4lDBT4tj6mNA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:0gwIi1RKrFI=:3aJY2DF+6MRXJO8QOz3Ood
 p53XXghGN8nyyElwOVM1LiJFMQOQtr9JeQVk3/kcYqQZUCxGZi8RImtuybHco3b6IjOflZ8CJ
 HtSTBKJLOZTuV2tPEbgSXAsVPrvnNv8ufXJgR2zCvxouavC5JrTUJmn8xelPvnhAe2iFjRMXh
 IkzXSDNG9HmdMmKx8v++LwROyJmX4Ep2xYNOsDdNFCPL0i3hk5T8n+Sv8/CopGOL6xQNv1Hqk
 IcgpB9sIqzI4OQDMZiCIS5QADfhT0v+kgawErfx+3Xc9K0J63ljM7hW4ARNco1AhK6j0t5QPC
 A3a5QanSQYBYLqLL/NW6TwfWOqTpVZ8zlXTSfnYZz1y7jWL3IBt6opLsOUyH1D90grUMN7EBD
 V74FSw8maRuxldLMwX7oSlTBLksUYVnBs4fpJ+du0ly2YWLjnVlReRK1RVGRzP/1VXo4XotIs
 rj5ii0bRAbivVdNuzIpjOhHb9mYAdKSZ1xV2iHk0M0kU6/zvC8efZIGBIg67w3saPRobwMrDR
 VcSRUpFEjswr+308Dw73ByZkqh9dIXuyLq/WLcfcaRPKVk8eX9w9a2DEQgGKsy9zYYM8BwZMx
 DHK1+qvv4GGdeZXUUiRpA0WT/Fy+CwHuCGaBgrTl6KgHXYiU2VuuycaX3pXXvgiBO+e7jv3NM
 4Y3wdP8wLCw/GC3IDPFlgyTSSq5oTsuGfKl/aDwp5CjfzibrukALuv0BiBYn1dBC7aLaAauhh
 jt923Vne0gw0y1FjN85FS0tnz/Hw4ixNmW8ossZ57SJvo6+raggJ4P/xywiy85TNzvYxlL6UL
 Rsqmr90
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> & is no longer allowed in column 0, since Coccinelle 1.0.4.

This information corresponds to the support for handling of conjunctions
in the semantic patch language which was added with the software
release "Coccinelle 1.0.3".
https://systeme.lip6.fr/pipermail/cocci/2015-October/002634.html


> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> -&c->member
> + &c->member

The added space character is not in the first column of this SmPL script.

* Can it be that the additional character will be transformed according to
  special pretty-printing rules?
  https://github.com/coccinelle/coccinelle/issues/37

* Is such a change a possible workaround for open issues around
  the message "minus: parse error" (or software improvements
  which were developed in the meantime)?


>  |
>  c = E
>  |


Does the shown tweak need any further considerations?

Regards,
Markus