From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993304AbcBSPPj (ORCPT ); Fri, 19 Feb 2016 10:15:39 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:24063 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932440AbcBSPPh (ORCPT ); Fri, 19 Feb 2016 10:15:37 -0500 Subject: Re: [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h To: "Luis R. Rodriguez" , hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de References: <1455891343-10016-1-git-send-email-mcgrof@kernel.org> <1455891343-10016-2-git-send-email-mcgrof@kernel.org> Cc: x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, rusty@rustcorp.com.au, david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org, jgross@suse.com, andriy.shevchenko@linux.intel.com, xen-devel@lists.xensource.com From: Boris Ostrovsky Message-ID: <56C73162.1040207@oracle.com> Date: Fri, 19 Feb 2016 10:14:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455891343-10016-2-git-send-email-mcgrof@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2016 09:15 AM, Luis R. Rodriguez wrote: > diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h > index 878e4b9940d9..232cff0ff4e3 100644 > --- a/arch/x86/boot/bitops.h > +++ b/arch/x86/boot/bitops.h > @@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr) > asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr)); > } > > +#define BIT(x) (1 << x) Parenthesize x.