From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427982AbcBSP4o (ORCPT ); Fri, 19 Feb 2016 10:56:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427522AbcBSP4n (ORCPT ); Fri, 19 Feb 2016 10:56:43 -0500 Subject: Re: [PATCH v2 02/14] KVM: x86: simplify atomics in kvm_pit_ack_irq To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1455736496-374-1-git-send-email-rkrcmar@redhat.com> <1455736496-374-3-git-send-email-rkrcmar@redhat.com> <56C607BB.3000103@redhat.com> <20160219155150.GC2456@potion.brq.redhat.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Yuki Shibuya From: Paolo Bonzini Message-ID: <56C73B37.6070901@redhat.com> Date: Fri, 19 Feb 2016 16:56:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160219155150.GC2456@potion.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 19 Feb 2016 15:56:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/02/2016 16:51, Radim Krčmář wrote: > The end result is going to be identical. I had a version that did > something similar and it was pretty tangled as well -- I wanted to > remove useless locks before re-using one for the ioctls. > (We need the protection earlier, because userspace can control notifiers > while PIT is still being initialized. And removing the lock had > dependencies.) Yeah, I eventually imagined that cleaning up the locks helps with the patch that adds/removes the notifiers dynamically. Then I guess your current ordering of the patches is good! Paolo