From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993152AbcBSRyX (ORCPT ); Fri, 19 Feb 2016 12:54:23 -0500 Received: from mail-lb0-f176.google.com ([209.85.217.176]:34887 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948557AbcBSRyM (ORCPT ); Fri, 19 Feb 2016 12:54:12 -0500 Subject: Re: [PATCH v4 1/2] usb: musb: Fix DMA for host mode To: Joshua Henderson , linux-kernel@vger.kernel.org References: <1455900093-15577-1-git-send-email-joshua.henderson@microchip.com> Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56C756BF.2070309@cogentembedded.com> Date: Fri, 19 Feb 2016 20:54:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455900093-15577-1-git-send-email-joshua.henderson@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 02/19/2016 07:41 PM, Joshua Henderson wrote: > From: Cristian Birsan > > Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in > musb_host.c part5") introduces a problem setting DMA host mode. > > This commit fixes the done condition that advances the musb schedule. > Without this patch the the msub_advance_schedule() is called immediately > after receiving an endpoint RX interrupt without waiting for the DMA > transfer to complete. As a consequence when the dma complete interrupt > arrives the in_qh member of hw_ep is already null an the musb_host_rx() > exits on !urb error case. > > Signed-off-by: Cristian Birsan > Signed-off-by: Joshua Henderson > Tested-by: Ladislav Michl Acked-by: Sergei Shtylyov Although you didn't describe your changes to the original patch in the change log... MBR, Sergei