From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993203AbcBSTHW (ORCPT ); Fri, 19 Feb 2016 14:07:22 -0500 Received: from casper.infradead.org ([85.118.1.10]:33762 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030273AbcBSTHU (ORCPT ); Fri, 19 Feb 2016 14:07:20 -0500 Subject: Re: linux-next: Tree for Feb 19 (rapidio: rio_mport_cdev.c) To: Stephen Rothwell , linux-next@vger.kernel.org References: <20160219154952.1bb036cd@canb.auug.org.au> Cc: linux-kernel@vger.kernel.org, Matt Porter , Alexandre Bounine From: Randy Dunlap X-Enigmail-Draft-Status: N1110 Message-ID: <56C767D4.1010003@infradead.org> Date: Fri, 19 Feb 2016 11:07:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160219154952.1bb036cd@canb.auug.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/18/16 20:49, Stephen Rothwell wrote: > Hi all, > > Changes since 20160218: > on x86_64 (for the past 3 days or so): when CONFIG_DMA_ENGINE is not enabled: ../drivers/rapidio/devices/rio_mport_cdev.c: In function 'mport_cdev_open': ../drivers/rapidio/devices/rio_mport_cdev.c:1938:22: error: 'struct mport_cdev_priv' has no member named 'async_list' INIT_LIST_HEAD(&priv->async_list); ^ ../drivers/rapidio/devices/rio_mport_cdev.c:1939:22: error: 'struct mport_cdev_priv' has no member named 'pend_list' INIT_LIST_HEAD(&priv->pend_list); ^ In file included from ../include/linux/seqlock.h:35:0, from ../include/linux/time.h:5, from ../include/linux/stat.h:18, from ../include/linux/module.h:10, from ../drivers/rapidio/devices/rio_mport_cdev.c:17: ../drivers/rapidio/devices/rio_mport_cdev.c:1941:22: error: 'struct mport_cdev_priv' has no member named 'req_lock' spin_lock_init(&priv->req_lock); ^ ../include/linux/spinlock.h:296:17: note: in definition of macro 'spin_lock_init' spinlock_check(_lock); \ ^ In file included from ../include/linux/seqlock.h:35:0, from ../include/linux/time.h:5, from ../include/linux/stat.h:18, from ../include/linux/module.h:10, from ../drivers/rapidio/devices/rio_mport_cdev.c:17: ../drivers/rapidio/devices/rio_mport_cdev.c:1941:22: error: 'struct mport_cdev_priv' has no member named 'req_lock' spin_lock_init(&priv->req_lock); ^ ../include/linux/spinlock.h:99:24: note: in definition of macro 'raw_spin_lock_init' __raw_spin_lock_init((lock), #lock, &__key); \ ^ ../drivers/rapidio/devices/rio_mport_cdev.c:1941:2: note: in expansion of macro 'spin_lock_init' spin_lock_init(&priv->req_lock); ^ ../drivers/rapidio/devices/rio_mport_cdev.c: In function 'mport_cdev_ioctl': ../drivers/rapidio/devices/rio_mport_cdev.c:2172:3: error: implicit declaration of function 'rio_mport_alloc_dma' [-Werror=implicit-function-declaration] return rio_mport_alloc_dma(filp, (void __user *)arg); ^ ../drivers/rapidio/devices/rio_mport_cdev.c:2174:3: error: implicit declaration of function 'rio_mport_free_dma' [-Werror=implicit-function-declaration] return rio_mport_free_dma(filp, (void __user *)arg); ^ ../drivers/rapidio/devices/rio_mport_cdev.c:2176:3: warning: passing argument 2 of 'rio_mport_wait_for_async_dma' makes integer from pointer without a cast [enabled by default] return rio_mport_wait_for_async_dma(filp, (void __user *)arg); ^ ../drivers/rapidio/devices/rio_mport_cdev.c:1136:12: note: expected 'int32_t' but argument is of type 'void *' static int rio_mport_wait_for_async_dma(struct file *filp, int32_t arg) ^ -- ~Randy