From: Jens Axboe <axboe@kernel.dk>
To: "Matias Bjørling" <m@bjorling.me>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] LightNVM patches for next 4.5-rc
Date: Fri, 19 Feb 2016 20:39:50 -0700 [thread overview]
Message-ID: <56C7E006.40600@kernel.dk> (raw)
In-Reply-To: <20160219191541.GB19208@kernel.dk>
On 02/19/2016 12:15 PM, Jens Axboe wrote:
> On Fri, Feb 19 2016, Matias Bjørling wrote:
>> Hi Jens,
>>
>> Here is a couple of patches for the next 4.5-rc.
>>
>> A patch from Alan that fixes up logic in nvm_configure_get. Another
>> patch from Javier that fixes a bug with multiple luns in RRPC, and at
>> last a patch from me that fixes the get bad block interface when
>> multiple planes are available on the media.
>
> Applied, but you need to update your patch base, patch #3 needed to be
> hand applied because your repo does not have the below applied.
>
> commit ff0e498bfa185fad5e86c4c7a2db4f9648d2344f
> Author: Javier González <jg@lightnvm.io>
> Date: Tue Jan 12 07:49:33 2016 +0100
>
> lightnvm: manage open and closed blocks separately
And even after that, it's broken:
drivers/lightnvm/rrpc.c: In function ‘rrpc_l2p_update’:
drivers/lightnvm/rrpc.c:1047:24: error: ‘struct rrpc’ has no member
named ‘nr_sects’
div_u64_rem(pba, rrpc->nr_sects, &mod);
^
I've dropped that patch. You need to step it up, that's way too lax for
something destined for the current series at -rc4 time.
--
Jens Axboe
prev parent reply other threads:[~2016-02-20 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 12:56 [PATCH 0/3] LightNVM patches for next 4.5-rc Matias Bjørling
2016-02-19 12:56 ` [PATCH 1/3] lightnvm: fix up nonsensical configure overrun checking Matias Bjørling
2016-02-19 12:56 ` [PATCH 2/3] lightnvm: fold get bb tbl when using dual/quad plane mode Matias Bjørling
2016-02-19 12:56 ` [PATCH 3/3] lightnvm: generalize rrpc ppa calculations Matias Bjørling
2016-02-19 19:15 ` [PATCH 0/3] LightNVM patches for next 4.5-rc Jens Axboe
2016-02-20 3:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C7E006.40600@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bjorling.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).