From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1429089AbcBTDj5 (ORCPT ); Fri, 19 Feb 2016 22:39:57 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:36092 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753290AbcBTDjz (ORCPT ); Fri, 19 Feb 2016 22:39:55 -0500 Subject: Re: [PATCH 0/3] LightNVM patches for next 4.5-rc To: =?UTF-8?Q?Matias_Bj=c3=b8rling?= References: <1455886619-3007-1-git-send-email-m@bjorling.me> <20160219191541.GB19208@kernel.dk> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <56C7E006.40600@kernel.dk> Date: Fri, 19 Feb 2016 20:39:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160219191541.GB19208@kernel.dk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2016 12:15 PM, Jens Axboe wrote: > On Fri, Feb 19 2016, Matias Bjørling wrote: >> Hi Jens, >> >> Here is a couple of patches for the next 4.5-rc. >> >> A patch from Alan that fixes up logic in nvm_configure_get. Another >> patch from Javier that fixes a bug with multiple luns in RRPC, and at >> last a patch from me that fixes the get bad block interface when >> multiple planes are available on the media. > > Applied, but you need to update your patch base, patch #3 needed to be > hand applied because your repo does not have the below applied. > > commit ff0e498bfa185fad5e86c4c7a2db4f9648d2344f > Author: Javier González > Date: Tue Jan 12 07:49:33 2016 +0100 > > lightnvm: manage open and closed blocks separately And even after that, it's broken: drivers/lightnvm/rrpc.c: In function ‘rrpc_l2p_update’: drivers/lightnvm/rrpc.c:1047:24: error: ‘struct rrpc’ has no member named ‘nr_sects’ div_u64_rem(pba, rrpc->nr_sects, &mod); ^ I've dropped that patch. You need to step it up, that's way too lax for something destined for the current series at -rc4 time. -- Jens Axboe