From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbcBUCIf (ORCPT ); Sat, 20 Feb 2016 21:08:35 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:36345 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbcBUCIc (ORCPT ); Sat, 20 Feb 2016 21:08:32 -0500 Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters To: joe@perches.com, clm@fb.com References: <1455992258-9176-1-git-send-email-tsimonq2@ubuntu.com> <1456020393-8418-1-git-send-email-tsimonq2@ubuntu.com> Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org From: Simon Quigley Organization: Ubuntu Message-ID: <56C91C1E.6010803@ubuntu.com> Date: Sat, 20 Feb 2016 20:08:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456020393-8418-1-git-send-email-tsimonq2@ubuntu.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I apologize, I had my text editor set to a 4 space tab instead of 8 so I couldn't see this clearly. That's fixed now, and it won't happen again. Is this what you wanted? It seems to line up exactly like you proposed. On 02/20/2016 08:06 PM, Simon Quigley wrote: > checkpatch.pl reported a warning of over 80 characters on line 1833 > > Adjusted to put &extref and &offset on a different line > > Signed-off-by: Simon Quigley > --- > fs/btrfs/backref.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c > index f6dac40..81b0863 100644 > --- a/fs/btrfs/backref.c > +++ b/fs/btrfs/backref.c > @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root, > unsigned long ptr; > > while (1) { > - ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref, > - &offset); > + ret = btrfs_find_one_extref(fs_root, inum, offset, path, > + &extref, &offset); > if (ret < 0) > break; > if (ret) { >