Re: [PATCH v5 2/8] clk: rockchip: rk3036: fix and add node id for emac clock

From: Caesar Wang <caesar.upstream@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Caesar Wang <wxt@rock-chips.com>,
	zhengxing <zhengxing@rock-chips.com>,
	linux-rockchip@lists.infradead.org, jeffy.chen@rock-chips.com,
	linux-kernel@vger.kernel.org, leozwang@google.com,
	keescook@google.com
Subject: Re: [PATCH v5 2/8] clk: rockchip: rk3036: fix and add node id for emac clock
Date: Sun, 21 Feb 2016 10:45:11 +0800	[thread overview]
Message-ID: <56C924B7.8090301@gmail.com> (raw)
In-Reply-To: <2143221.dkVJ5VuQke@phil>

Heiko,

在 2016年02月21日 10:26, Heiko Stuebner 写道:
> Hi Caesar, Xing,
>
> Am Dienstag, 2. Februar 2016, 11:48:19 schrieb Caesar Wang:
>> From: zhengxing <zhengxing@rock-chips.com>
>>
>> In the emac driver, we need to refer HCLK_MAC since there are
>> only 3PLLs (APLL/GPLL/DPLL) on the rk3036, most clock are under the
>> GPLL, and it is unable to provide the accurate rate for mac_ref which
>> need to 50MHz probability, we should let it under the DPLL and are
>> able to set the freq which integer multiples of 50MHz, so we add these
>> emac node for reference.
>>
>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> [...]
>
>> --- a/drivers/clk/rockchip/clk-rk3036.c
>> +++ b/drivers/clk/rockchip/clk-rk3036.c
>> @@ -343,8 +343,11 @@ static struct rockchip_clk_branch
>> rk3036_clk_branches[] __initdata = { RK2928_CLKSEL_CON(16), 0, 2, MFLAGS,
>> 2, 5, DFLAGS,
>>   			RK2928_CLKGATE_CON(10), 5, GFLAGS),
>>
>> -	COMPOSITE_NOGATE(0, "mac_pll_src", mux_pll_src_3plls_p, 0,
>> -			RK2928_CLKSEL_CON(21), 0, 2, MFLAGS, 9, 5, DFLAGS),
>> +	MUX(SCLK_MACPLL, "mac_pll_pre", mux_pll_src_3plls_p, 0,
>> +			RK2928_CLKSEL_CON(21), 0, 2, MFLAGS),
>> +	DIV(0, "mac_pll_src", "mac_pll_pre", 0,
>> +			RK2928_CLKSEL_CON(21), 9, 5, DFLAGS),
>> +
> CLK_SET_RATE_NO_REPARENT should do the trick as well.
>
> And the whole hclk + clkid part should be separate patches. I took the
> liberty of splitting them already in [0] to see if I could get the emac
> running on my kylin board.
>
> Probing emac + phy does suceed, but there is no link-detection.
> Building your kylin-develop4.4 branch [1] results in the same (aka no
> transmission).
>
> Only with the original uboot + 4.1-based kernel that was already on the
> device did I manage to get a network connection.

I guess you need apply the uboot patch[0].

patch[0]:
http://lists.denx.de/pipermail/u-boot/2016-February/245814.html

or get the uboot from rockchip github:
https://github.com/rockchip-linux/u-boot/commits/rk3036

>
> Is there some additional setup missing somewhere?
>
>
> Heiko
>
> [0] https://github.com/mmind/linux-rockchip/commits/tmp/rk3036-emac
> The 3 additional patches are not strictly necessary there.
>
> [1] https://github.com/rockchip-linux/kernel/tree/kylin-develop4.4

The lastest kylin-develop.4.4.y from my github:
https://github.com/Caesar-github/rockchip/tree/kylin/develop-4.4.y

>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

-- 
Thanks,
Caesar