From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754180AbcBVJVM (ORCPT ); Mon, 22 Feb 2016 04:21:12 -0500 Received: from mail-bn1on0063.outbound.protection.outlook.com ([157.56.110.63]:58573 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751845AbcBVJVG (ORCPT ); Mon, 22 Feb 2016 04:21:06 -0500 Authentication-Results: spf=pass (sender IP is 137.71.25.55) smtp.mailfrom=analog.com; arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=bestguesspass action=none header.from=analog.com; Reply-To: Subject: Re: [PATCH] misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes References: <1447863375-2195-1-git-send-email-dan.bogdan.nechita@gmail.com> <564D86E3.4030509@analog.com> To: Dan Bogdan Nechita , Arnd Bergmann , Greg Kroah-Hartman CC: From: Michael Hennerich Organization: Analog Devices Inc. Message-ID: <56CACDB3.3000804@analog.com> Date: Mon, 22 Feb 2016 09:58:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <564D86E3.4030509@analog.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD032;1:wNUPUbKfItbXB7kSM9S040r2z0TyXoyDCcHwAb7IDXDTH3t+YGZNRjDe6ghAK9e9QgCMLSZN6R8JplFtaki8ZlBeon2oDAQvD4bMzZb6jQJQ8xRA8tG62wIN9YjQnnxomZsKL1uEpF3BX7nChWM9INwxufPh40ufjgX4OyqMYpyMBCfvU6XTcoWZBEsiW1lk1fvgmddxQ736T1avz0d9Y+3lU/stwM+6nafC9L14gugGcSKpbc14F5S1dvFpxgDincMuzq0x1jnpjdMN6qeoWU+FRXyH0mOPyU7qTkML1J0A5ZLP7yjqeqyhYtDWzXFpiswqsV+Zt85HFqDhI5BRv2x+5cJro/ecgOTjcrb/o8+tMV00OQypK4EgUrn2SpBzjNnAmOAFq+03zByBu/hhEUPy7EvlHwl6O4rjHZ26v8I9ED53B585N84Mujtxk6E6gdihhReziwi4UF7+fPWRww== X-Forefront-Antispam-Report: CIP:137.71.25.55;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(377454003)(479174004)(199003)(24454002)(5001770100001)(33656002)(4001350100001)(23746002)(65816999)(76176999)(5001970100001)(43066003)(54356999)(87266999)(83506001)(50986999)(2950100001)(77096005)(86362001)(36756003)(50466002)(106466001)(87936001)(2906002)(4326007)(3450700001)(5008740100001)(11100500001)(6806005)(230700001)(586003)(64126003)(1096002)(1220700001)(65806001)(65956001)(47776003)(189998001)(19580405001)(19580395003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0301MB0758;H:nwd2mta1.analog.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 148ae335-f6df-46d1-7a99-08d33b675a84 X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0758;2:trmtu09Y3RISbeWhR/0m+xnEmTKq2NLs3IakbYCPEk9DwEnwFhFu3iu4VsBpJ85OP0jL64cuDhUTlsfHLNBwdIsjjlDS/rlakCq7ejONL3FGfijwT8kiYdA/ZbC+hlvDjv5vEA8cPE+ng8Bnn0kuw0yPKQmGXWstVcdhKiMPNvj+ZxDRgTVOpj91GAzvEbpN;3:rrugRok8C0mdPiqVG0JFBRVW/ibFVZABLZVKUaFn2sily+XBXI1/OQxesKJq6KJHJ5R6fvlGrURit31FC6bett2zuBs2SHQjJkn9oQJ9YMrfAZLR/G8fnV38RI+ZMFVuEtgAjq3DBg6p4yyrtOdE3B2GvB4AKs0XDqiNJQizA9SRducDR2mmDuBTms3Mi9oNi12XaYncoBGTbIWySpS4P/2C7wjkKoOxIgB0XUv8y6OOhj0gzZt+UE7N9PrLg+kS4cix0vfWnsJhrOJL16QLrQ==;25:96eyWPXDVKr8dvXE72fo61x8M8iJeb6BlQP8NTM8NJ+xY7TzFXV0e817scTfy5mwHzT4Alif1EIjB2DqxO/Hw2lp2yNC8NiZh1zoPRHUgaCgGvQJzBpPsi/KHUctSjMYIm+w0QVpmE83uyN3OMkyRvKgjr6+vtx8DZ013rZ3eGMR+OwnFoCPJH7sh5iJG7heK45p4OUATLEzltSx8AtHNl46Sd6V8/kB55HdLYWGoWJMoriGex0i6MjoUnRlvThFnypfum/tVvcj3a8loJaeiSg36lLnyXA9G7gyLlwU0hgnZWf73VHUl9W2ZEhSKWpIOCnCGgSWFgWCpTk6W2o9Zb/65D/5JTPZsuJrqEeUxiM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BY2PR0301MB0758; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0758;20:6oaGAuidGTpuzcvZW5RRPhs+xmpieerej9ZaGhd0tf/y61KFMhb5M1XlLXfqiRSkKToVGOiy6G6E5E4dwyNeZBeFOutv3Q24h6Cs4HIWY4zQXBWdlSpuYfbbZSErQoY/Sm47eN8H6xjdxus7nqM7Etly1aO7BAm+Zh/9F+UnDw3F7v5dwg6uc9oTudlNbLaInqza0QfiMtoefGPfiY/jr0z57dQgdF5srs+zCigaIkV3WjD0yrWcvKcOGJHRczUUKVZ8gOByL4IWL0y6gRz5X8eoyIFhFgIAyZ+X1sNieG8hZWTuT7PTTabzHqSUlpB/3/v6Dr631J8LUqSIZ9fJCf/KU2fgaPyT8I+FdutT8A+pztdujFYbMHwpQGFvZSf+kMHwvdNzybQxpe81pPz/6rhDy/SNL6uZSQd9hA+IQm33fIYky38UEl8l9mWKBYRjbxdzZwh2MYPwMVim1QcaNLZuL3PaYtuXO/xyzEJ6nVtUisUkqvLReKZIIHAb5DDM X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(13023025)(13018025)(13017025)(13015025)(5005006)(8121501046)(10201501046)(3002001);SRVR:BY2PR0301MB0758;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0758; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0758;4:/P5mLzz6611D1JNfjvx/EbebtFrE0MwReHSNpJ8v4nx7FbGiAVcf1T+C4yVtpEZZ2pTbngCF/sBtY53fEl6M2LMyuCLzx/L/4N2xCPb/dSiIraC4KLakoSOVEbaJU2QBRryUj53PHqLAbBWmG8bFjyJFuG0pEjT82Bl0YVDw8HJ93nY2M9WCFz7jxwcUmTjhbto0nUL8acznmTsjxEQ9d1tzJNhf9i2KLoNNykIv49xZRudo9ze0aIxvq6Q+sCvNIV3IPAhrTTp0bph+GH+pe1RaJpEYtaVKkQt9XZYcCg22mHBlyx6T/KIMnkGARBFpxXXg7WVFJv4n7t/8AqHrlf+EbHNPD5dFa7Pdy1YCsjeAhUSVZpV1OQbLWXw98Ui/OCIx5mar4ljf3OQYnusZ+fYUvGmz1HabUhkTVbH6O/s/023exw/5L0pRETLIaadnL26mQBCFdlyfrJXF0Dms5A2zU4UhNSEUPBx9vBA+uj0wPzcwzkTamASlTwL/rwfD X-Forefront-PRVS: 0860FE717F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR0301MB0758;23:/NCVojulLkqw2nIiI5KexI0p7luJrAS1dnj?= =?Windows-1252?Q?+b7MncD5IwQHy1MVcP9js6DSNKE/GNWhm4k9NOC1F/weD4USX5Yy22k/?= =?Windows-1252?Q?oKKpzfmQUqbWcICbXTtxPhxd9qdWQ5KUgwrQlhUATu/Aj1iCDgC7cNTK?= =?Windows-1252?Q?V2/Zni3Ic8eOdWxDOEseRiXZqO8Pj2EjyXvFwz5PH7eAEsEz/O+7GHOc?= =?Windows-1252?Q?1+49gedoXN9Nny2F1kB9H1nA1V7l7tPiCJbTkKwWbp60YaYYWWo3UMoT?= =?Windows-1252?Q?9KAGjdzubqGiCTjLWVz4N0FkU0fWEPF9PQCCixnX8E8+7gNMRV5TtAv2?= =?Windows-1252?Q?RHCeEOwpFTA4OkGKei+hUIyMxW6RBaospEibOpnKihRyadNu+v1qVr03?= =?Windows-1252?Q?ok4O4GpTLhgkGWgWVsuRDky+7Za3tIKbSQv4xqqa9kf+Zc3aXyoaswEe?= =?Windows-1252?Q?Vh07+a8aH0yhZLFLbf1W0aVduDxxKpqE9IEx5vACqQW3Yv/XjfpN7ZTi?= =?Windows-1252?Q?IjfCwgUy1yCI+l9yMwydmx6WbyEg8yqepOa+C3q8wQe/Cmi4b1+MbA7v?= =?Windows-1252?Q?aXCkaBqDZ9B851S68/kiPu/nb2BxIy9q38A44UZ62ZLbwpoasvJeQZbO?= =?Windows-1252?Q?oR4ydu1uGJoLoFIwWy6i+WC8jC2cFOAm1skJHQUJPrjFSb9qf08xtOYY?= =?Windows-1252?Q?fj56lOGrj81lsrL3VIxaYdcO6F3X8WhslMJlU2rxfNyBlEYP/CH5fxPN?= =?Windows-1252?Q?B0CFUZN0KiEjfw1sEWQQVAoIEkO7S+YFUcnYUPzhFHdat9erW0AGxVnX?= =?Windows-1252?Q?XHOUk1YrAv6UrDDrMQdilSGvaYlCjzFL0PBpxaJR0QOagWtNnFYJn/Wf?= =?Windows-1252?Q?IGGX/XH549sPRwuGldzuwKxo153KTrbEV6PW7ppqUP6Wbg8jnSx8CWlT?= =?Windows-1252?Q?OjqSMnj8zh7kKSy4brO6sBx2N4hHgqx9hX7IepV4RFzY2+RYK0P8rdRf?= =?Windows-1252?Q?Al6z6lEkJzPW2OlYVyfS9x/Kw5jcpxLbg1MUP2jvOVxz7L0CB83KL/Gq?= =?Windows-1252?Q?LoKlcbKa1DqqBLkW62enNAnd88suzLucI9N/JGgw8DLKyoG9+T+UbTMZ?= =?Windows-1252?Q?E+RzIE4tuT/nBggDgaSd2NWujXq0iv7M3vFt5W9TNK02YMRCOz638rsp?= =?Windows-1252?Q?lYbRCR9sqRiPB+GdlsP60/Fmj9H8Xa7jQ/oNqduicvvn5UwEQfb2gfSo?= =?Windows-1252?Q?mCWDQcBT/MQML26nRPQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0758;5:y4pwGqB1+0lWEzYp1dV1tSxqtXhZpLS/aQY2Z2uECRFYtifGcDGCQfWUZMT/sD08CHInsuIBtXet/9GiioUDITAE6bv5yuAiuKv7/yoATVN+EsZJDp2ICtVNslYqnImQj+OZI67dtp6ielOQYGcrKQ==;24:oA8Y5BOXnKdLZmzdCged6iriBewMNZb4xNf0Oh84v9Yr9dpt/PeZ79sVmhjFGuEa4FXHelq63IFS/L0Ke+C7dnHFVDo2o4GygD+AgNwtrN8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2016 09:05:47.4425 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0758 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/2015 09:22 AM, Michael Hennerich wrote: > On 11/18/2015 05:16 PM, Dan Bogdan Nechita wrote: >> Currently writing the attributes with "echo" will result in comparing: >> "enabled\n" with "enabled\0" and attribute is always set to false. >> >> Use the sysfs_streq() instead because it treats both NUL and >> new-line-then-NUL as equivalent string terminations. >> >> Signed-off-by: Dan Bogdan Nechita > > Acked-by: Michael Hennerich Looks like to patch got lost? > >> --- >> drivers/misc/ad525x_dpot.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c >> index 15e8807..4230e6a 100644 >> --- a/drivers/misc/ad525x_dpot.c >> +++ b/drivers/misc/ad525x_dpot.c >> @@ -452,7 +452,7 @@ static ssize_t sysfs_set_reg(struct device *dev, >> int err; >> >> if (reg & DPOT_ADDR_OTP_EN) { >> - if (!strncmp(buf, "enabled", sizeof("enabled"))) >> + if (sysfs_streq(buf, "enabled")) >> set_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask); >> else >> clear_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask); >> > > -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif