From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
mark.rutland@arm.com, ynorov@caviumnetworks.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: compat: Check for AArch32 state
Date: Mon, 22 Feb 2016 11:37:42 +0000 [thread overview]
Message-ID: <56CAF306.1060102@arm.com> (raw)
In-Reply-To: <20160209173606.GX22874@arm.com>
On 09/02/16 17:36, Will Deacon wrote:
> On Thu, Jan 28, 2016 at 11:32:17AM +0000, Suzuki K Poulose wrote:
>> Make sure we have AArch32 state available for running COMPAT binaries.
>> */
>> seq_puts(m, "Features\t:");
>> - if (personality(current->personality) == PER_LINUX32) {
>> + if (system_supports_32bit_el0() &&
>> + personality(current->personality) == PER_LINUX32) {
>
> Wouldn't it be better to prevent tasks changing to the PER_LINUX32
> personality on systems that don't support AArch32 at EL0?
Yes, thats the ideal solution. I took a look at it and it requires us to
hook in arm64 wrapper for the personality syscall. I will take a look.
Thanks
Suzuki
next prev parent reply other threads:[~2016-02-22 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 11:32 [PATCH 0/6] Support for systems without AArch32 state Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 1/6] arm64: hwcaps: Cleanup naming Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 2/6] arm64: HWCAP: Split COMPAT HWCAP table entries Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 3/6] arm64: Add helpers for detecting AArch32 support at EL0 Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 4/6] arm64: cpufeature: Check availability of AArch32 Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 5/6] arm64: cpufeature: Track 32bit EL0 support Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 6/6] arm64: compat: Check for AArch32 state Suzuki K Poulose
2016-02-09 17:36 ` Will Deacon
2016-02-22 11:37 ` Suzuki K. Poulose [this message]
2016-02-22 14:03 ` [PATCH 0/6] Support for systems without " Suzuki K. Poulose
2016-02-22 14:38 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CAF306.1060102@arm.com \
--to=suzuki.poulose@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).