linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Jean Delvare <jdelvare@suse.de>, LKML <linux-kernel@vger.kernel.org>
Cc: "Alan Tull" <atull@opensource.altera.com>,
	"Moritz Fischer" <moritz.fischer@ettus.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver
Date: Mon, 22 Feb 2016 16:04:34 +0100	[thread overview]
Message-ID: <56CB2382.9090709@xilinx.com> (raw)
In-Reply-To: <20160222144255.18cd14ee@endymion>

On 22.2.2016 14:42, Jean Delvare wrote:
> The Zynq FPGA manager driver serves no purpose on other architectures
> so hide it unless build-testing.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Alan Tull <atull@opensource.altera.com>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
> ---
> Michal, Sören, I'm not sure if the driver is needed on ARCH_ZYNQMP too?
> 
>  drivers/fpga/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-4.5-rc5.orig/drivers/fpga/Kconfig	2016-01-11 00:01:32.000000000 +0100
> +++ linux-4.5-rc5/drivers/fpga/Kconfig	2016-02-22 14:11:33.142068843 +0100
> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>  
>  config FPGA_MGR_ZYNQ_FPGA
>  	tristate "Xilinx Zynq FPGA"
> +	depends on ARCH_ZYNQ || COMPILE_TEST
>  	help
>  	  FPGA manager driver support for Xilinx Zynq FPGAs.
>  

This driver is zynq specific. ZynqMP will have different driver.
I have no problem to limit this driver just for Zynq.
Currently I am not aware about other usage without changes in the driver.

Thanks,
Michal

  reply	other threads:[~2016-02-22 15:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 13:42 [PATCH] fpga manager: Add hardware dependency to Zynq driver Jean Delvare
2016-02-22 15:04 ` Michal Simek [this message]
2016-02-22 17:20   ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CB2382.9090709@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=atull@opensource.altera.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moritz.fischer@ettus.com \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).