[PATCH] fpga manager: Add hardware dependency to Zynq driver

[PATCH] fpga manager: Add hardware dependency to Zynq driver

[Jean Delvare]

The Zynq FPGA manager driver serves no purpose on other architectures
so hide it unless build-testing.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Alan Tull <atull@opensource.altera.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
---
Michal, Sören, I'm not sure if the driver is needed on ARCH_ZYNQMP too?

 drivers/fpga/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-4.5-rc5.orig/drivers/fpga/Kconfig	2016-01-11 00:01:32.000000000 +0100
+++ linux-4.5-rc5/drivers/fpga/Kconfig	2016-02-22 14:11:33.142068843 +0100
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on ARCH_ZYNQ || COMPILE_TEST
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver

[Michal Simek]

On 22.2.2016 14:42, Jean Delvare wrote:
> The Zynq FPGA manager driver serves no purpose on other architectures
> so hide it unless build-testing.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Alan Tull <atull@opensource.altera.com>
> Cc: Moritz Fischer <moritz.fischer@ettus.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
> ---
> Michal, Sören, I'm not sure if the driver is needed on ARCH_ZYNQMP too?
> 
>  drivers/fpga/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-4.5-rc5.orig/drivers/fpga/Kconfig	2016-01-11 00:01:32.000000000 +0100
> +++ linux-4.5-rc5/drivers/fpga/Kconfig	2016-02-22 14:11:33.142068843 +0100
> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>  
>  config FPGA_MGR_ZYNQ_FPGA
>  	tristate "Xilinx Zynq FPGA"
> +	depends on ARCH_ZYNQ || COMPILE_TEST
>  	help
>  	  FPGA manager driver support for Xilinx Zynq FPGAs.
>  

This driver is zynq specific. ZynqMP will have different driver.
I have no problem to limit this driver just for Zynq.
Currently I am not aware about other usage without changes in the driver.

Thanks,
Michal

Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver

[Moritz Fischer]

Hi Jean,

On Mon, Feb 22, 2016 at 7:04 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 22.2.2016 14:42, Jean Delvare wrote:
>> The Zynq FPGA manager driver serves no purpose on other architectures
>> so hide it unless build-testing.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
>> Cc: Alan Tull <atull@opensource.altera.com>
>> Cc: Moritz Fischer <moritz.fischer@ettus.com>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>

Acked-by: Moritz Fischer <moritz.fischer@ettus.com>

Thanks for catching that,

Moritz