From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753133AbcBVPUI (ORCPT ); Mon, 22 Feb 2016 10:20:08 -0500 Received: from mail-cys01nam02on0073.outbound.protection.outlook.com ([104.47.37.73]:30118 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751789AbcBVPUF (ORCPT ); Mon, 22 Feb 2016 10:20:05 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver To: Jean Delvare , LKML References: <20160222144255.18cd14ee@endymion> CC: Alan Tull , Moritz Fischer , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= From: Michal Simek Message-ID: <56CB2382.9090709@xilinx.com> Date: Mon, 22 Feb 2016 16:04:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160222144255.18cd14ee@endymion> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22146.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(377424004)(24454002)(199003)(164054003)(92566002)(83506001)(50466002)(2870700001)(77096005)(19580395003)(19580405001)(106466001)(80316001)(5001770100001)(4001350100001)(2950100001)(64126003)(33656002)(86362001)(6806005)(11100500001)(54356999)(87266999)(76176999)(189998001)(5001960100002)(107886002)(23676002)(87936001)(50986999)(63266004)(65956001)(1220700001)(4326007)(1096002)(47776003)(4001430100002)(36756003)(5008740100001)(65806001)(2906002)(586003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2NAM02HT137;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 5026b974-13c7-4d55-9f0c-08d33b9980f2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BL2NAM02HT137; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592)(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13018025)(5005006)(13017025)(13023025)(13024025)(13015025)(10201501046)(3002001);SRVR:BL2NAM02HT137;BCL:0;PCL:0;RULEID:;SRVR:BL2NAM02HT137; X-Forefront-PRVS: 0860FE717F X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2016 15:04:46.7072 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2NAM02HT137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.2.2016 14:42, Jean Delvare wrote: > The Zynq FPGA manager driver serves no purpose on other architectures > so hide it unless build-testing. > > Signed-off-by: Jean Delvare > Cc: Alan Tull > Cc: Moritz Fischer > Cc: Michal Simek > Cc: "Sören Brinkmann" > --- > Michal, Sören, I'm not sure if the driver is needed on ARCH_ZYNQMP too? > > drivers/fpga/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-4.5-rc5.orig/drivers/fpga/Kconfig 2016-01-11 00:01:32.000000000 +0100 > +++ linux-4.5-rc5/drivers/fpga/Kconfig 2016-02-22 14:11:33.142068843 +0100 > @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA > > config FPGA_MGR_ZYNQ_FPGA > tristate "Xilinx Zynq FPGA" > + depends on ARCH_ZYNQ || COMPILE_TEST > help > FPGA manager driver support for Xilinx Zynq FPGAs. > This driver is zynq specific. ZynqMP will have different driver. I have no problem to limit this driver just for Zynq. Currently I am not aware about other usage without changes in the driver. Thanks, Michal