From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754385AbcBVPyK (ORCPT ); Mon, 22 Feb 2016 10:54:10 -0500 Received: from mail-by2on0071.outbound.protection.outlook.com ([207.46.100.71]:21035 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754055AbcBVPyI (ORCPT ); Mon, 22 Feb 2016 10:54:08 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.174) smtp.mailfrom=sandisk.com; oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-d23ff70000000e62-a7-56cb2b803c41 Subject: Re: [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR) detection support To: David Miller , References: <1455967804-27644-1-git-send-email-santosh.shilimkar@oracle.com> <1455967804-27644-12-git-send-email-santosh.shilimkar@oracle.com> <20160221.223656.2213596964617869651.davem@davemloft.net> CC: , , From: Bart Van Assche Message-ID: <56CB2B7E.5000402@sandisk.com> Date: Mon, 22 Feb 2016 07:38:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160221.223656.2213596964617869651.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsWyRoxnkW6D9ukwg+XTGS3mnG9hsbi8aw6b xbNDvSwWxxaIWTyccJ7FgdVjy8qbTB4fn95i8fi8SS6AOYrLJiU1J7MstUjfLoEr49LuL4wF Czgr9vzcxdTAeIS9i5GTQ0LAROLO5oVsXYxcHEICmxgl5jQ2skA4OxglPnY1wlUduX+JDcQW EpjLKDGjyQbEFhYIl7j8ZA4jiC0i4Cbx5sAPVojmM4wSX/s2MXUxcnAwC8RIXO7JAKlhEzCS +PZ+JgtImFdAS6LpjQBImEVAVWLJxtssILaoQITE4c4usLW8AoISJ2c+AYtzAo3/u+MEC8RE e4kHW8tAwswC8hLb385hhrhyFavEq/NJEFeqS5xcMp9pAqPwLCSTZiF0z0LSvYCReRWjWG5m TnFuemqBoZFecWJeSmZxtl5yfu4mRnAEcGXuYFwxyfwQowAHoxIPrwbTqTAh1sSy4srcQ4wS HMxKIrx1UqfDhHhTEiurUovy44tKc1KLDzFKc7AoifNat6iFCQmkJ5akZqemFqQWwWSZODil Ghj9m56yu9ZcPvxylrpGn2fTmV2PdQ/MueL/KDt2qsj13ZW//whlP121+pCHs1sAy+rFT1Pu 9CY7C8/mNP+m45K89f3RRdHf+vjC/vr836hWsHfrWsPtBQ3H762/K5B2Krf+4UavA/+u2Bx5 zNy+eaNTRKbRX7Our2sF3oiwvGkRKlV93BttrRKnxFKckWioxVxUnAgA2BhCrHwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMJMWRmVeSWpSXmKPExsXCtZEjRbde+3SYQc8PVYs551tYLC7vmsNm 8exQL4vFsQViFg8nnGdxYPXYsvImk8fHp7dYPD5vkgtgjuKySUnNySxLLdK3S+DKuLT7C2PB As6KPT93MTUwHmHvYuTkkBAwkThy/xJbFyMXh5DAbEaJzjebWEESwgLhEpefzGEEsUUEXCTe 9LSwQhSdYZT42reJCSTBLBAm8WHPfLAGNgEjiW/vZ7J0MXJw8ApoSTS9EQAJswioSizZeJsF xBYViJA43NkFtphXQFDi5MwnYHFOATeJvztOsECMtJW4M3c3M4QtL7H97RzmCYx8s5C0zEJS NgtJ2QJG5lWMYrmZOcW56ZkFhkZ6xYl5KZnF2XrJ+bmbGMHByBm1g/H6RPNDjEwcnFINjL68 tt/4bNiVj39dfOb07xRr+drPPpP23L5+evcxgUviXXHzdjTNjrPWPPr065SYDg3LaU5tbfeP pSQ3689/er3FoY85wSvY3nHh6W9SF2q1Xv47c+nFdTMXbvO/clZx3cX/b1xL4hefc2SuXnCf v6jyAk2uQ6IfUq9t6FWc/8Gq9lDshFnZHUosxRmJhlrMRcWJAPZtkaz2AQAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC005;1:r94qPalfYnjKXKZRkmYkqXAvZ5orx0Al9TDeHg0uQ1+9e21HbAo4UbFo/jp15P14tq7Tpm19kj2KjFnnU2XPmUVZhRTK4AsB6DPR6chgEFdmZF3ITBt1a1JJ4+HZWMdEHovLVNdKp5KfvPXNZ3w+1fQQjustaYvH1GZ9CJjbmvQ2b8enOK+mcdsNFi9znfP9eaAjkgFH7s6iC1a/V1Wc1rOGTaF1UXcg3XZS24LeMaQkuDk5NMDuUYV3f2VF12aTxavWmza68iZRnUEVMxFIQKK4nR2nJb736TSo72EkVHUHc8KQfWjDTljtS0Ca2Sid78JlCM4Bh/+9cpISJlQGiQ6e0nQ0H1ld4EYFl//Rr3iaTTW21nvTU4ER84m4w4SI8OusOIvD3e/NBnGBU2jV1EnIM5cV4sTKqepq5EJFDuE= X-Forefront-Antispam-Report: CIP:63.163.107.174;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(479174004)(189002)(199003)(586003)(1220700001)(65956001)(1096002)(33656002)(5008740100001)(230700001)(2906002)(2950100001)(64126003)(77096005)(4326007)(5001770100001)(83506001)(5001960100002)(19580395003)(80316001)(50466002)(19580405001)(4001350100001)(189998001)(92566002)(23746002)(36756003)(87936001)(106466001)(11100500001)(47776003)(65806001)(87266999)(65816999)(50986999)(76176999)(54356999)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0201MB1616;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1616;2:lPZ/3h8Ixhfq7mROhtBSsURYr+znOQoVhE/zY3LwOrhvqN2toOR3q9rh8DyEfa49M8KU1ydx0wZykCgzej26RXiJ+hYaa0/ttNzPPONW91bX7Z2z/VilEC5nN2aour1/aZpgeMeyp7AdAmlqC7+AHw==;3:bd3TXDytNC3DbqDGCC7C+S6mfhIfOYJm+deEPEqkQoZRcnvczG5Wbdyv9+R+i3AGsEZmlwmXIQwxANKSDwJOHhGpRB8r6nG/xAXyvBh/mDJGDYJCbno1oBhrgUg9KmBRqqQtllUJcQsa6dv0JpNcaRsQeoCc1PMHXT0Y2S/1OfMdGocjOY02/9b8wJTjJqVcKfSJsnbNZ1jRbJcbJSD/jO2XC6dsVyoiwIkp9W8YwGS/ryhQ/0ElCvVKi+AM1bJO1cV+7O6M/Cq7T9NER06PPg==;25:Dqsg6AwtDoWnkGnWX4BXlF6WjFjVp/607S9A3oogdrSL/hUPVSaw02+j8zXIytyjniqEnNalY91oau2LWxsyES1bdiIBuX7Iwpcs1GzdatqE+juXtZAVSTqqFXZZ+9HPgmDI9zjnWsaAWgN9IyCUGwmgM1dbd7bZXUFcjKUgRHQcfQVPBMHtk5DjdN0UOJ5/Brok4I3I83OW+Apn5b14tt2wssRfyBFg3mshFaZ4vcZp3HAXLfdc1PViqyRl/wfcWTx9pUTqoU0HiNvmT9U1jiAAkXZ0BOSvBq3XGnUzgiPCl5SFYg3fbqc34cFh4l9NexRezs4ybdpCTA1jJ4iwioxuBevsKwtqG+4IS4n50M0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:SN1PR0201MB1616; X-MS-Office365-Filtering-Correlation-Id: 574d0a6b-26d1-44d0-643b-08d33b9e3d59 X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1616;20:tA5GlTD8gPNbInkZhR6JrRRRz1o026XVDr2rx1nQ0oCaWtNAb+7MelECqHkmd+SbWyKYlSqH/19CpL2gw9JHSpzAiHAmQ6ZvZ9X9Yq87sA8f6GN30Xa1/2tSYk8xQXHhx9sL6tPgC1yqvR5AQso1vJViG5ZUO+H5tHemOI3bjchitfS4icacN5DOb0hA9E+NcGmK4Ycl9Aj/NQGbkptDqFXQKo7nsJM8GALTvNvsv6NoQwXWmp3nzkvxx+gB1cSgHiOrIKyQJ0HEBFO+0JV9+hmzBlf7zFvptoFvYp+UbQN30jDdYxuSsfeKC/Pl7CECaDwK+GAsJ9KKR9/QJEYUQMA4RBX6RBJR39HU4ei4DtUJ+1YD3hykLY8s1dJMkLNc1OSpQ07ZmTB0GAIWBlPvxGtH/muvxOTSj2b0OE7f/F8E3ePmQAwO4uSqiNhUnV/Kv+TlADuHoFBUMEjac7GxfgyGCSk6eliV7zsYmokMLepGbcEpXOmGCVCSrYDaAlPU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13015025)(13023025)(13024025)(13017025)(13018025)(5005006)(10201501046)(3002001);SRVR:SN1PR0201MB1616;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1616; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1616;4:sHNV1XF2jLcEmcRprI3bh8pbVAmE3ADE6GU5ELCDEqSAXpBK/x3sK00IvraYMr/yvvqkFwGzt0/H1G+rvf/CsLeXStiLcqRKjtMLc8br1NKtYbRtwUFaWGPKlWIhlo/lq7oTn1/pjR6e3uk5LEq4qUK81qUPmyyERTOxwTVSMROG/a3ly/b5A1xlwtClSs2foEceXcshkqBBG/Oz3JA6yRcN6sHlUK8rKF6hU+cnKL4tXl58td87xbORM7A4SLOx17OVOAhzwZu4F02r5teAPuJ+NFndtC2y6ugBCF3bxJHx8BFGm7/M5fxTdIHDRT4/LBpRIBA81mw6YQE9IV8ZuhR+a7zgSDdiOb7/AFr9zQuio+AkysV9/7MCWozAvH5VtIwVcfFcQWoTotNAlZcGnVbr8TFJyUxsT3aNHiuUHpf6uis/+Le7PXpsXw/sSyxUVXrxOjbwF+eD92wTjujEpg== X-Forefront-PRVS: 0860FE717F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR0201MB1616;23:gdoxfY6b7Kto8FQccX9Jrc2pSWRSLXRTpnN?= =?Windows-1252?Q?ZH5cqjKg1KmFwR+pAUPioGd0/Ow+hSoiHl/NhLYThseS5kQylBoIPy3K?= =?Windows-1252?Q?M2VhsRQFydN07n4Gj5/Fy/Z0j0sCDhzd6jVT3miwrKmMF5FhVMAK25xS?= =?Windows-1252?Q?0HLV3vYQlqbNmcJubMH2fFgRt6C6En7SB5z2KMFa8jF9gRgetkZ6M6YS?= =?Windows-1252?Q?wtQS0SB2XQGlTcWt/i6Ak9rwyS6Mj8/kWEeEifTAhn4EL0DxIwHqnOyZ?= =?Windows-1252?Q?GP9x3OuSFtEoUP4NIrXENycgsmb4oZGLr3JgkqiIgGJsAxWhAPTYDCev?= =?Windows-1252?Q?JzMG6WJvQ9bI44jZjLWqf1CKNuV/Kp6gW7h/STf1IQxQp81R8b2XQCA+?= =?Windows-1252?Q?KuXsBKG7rry596dx+VbF/SkLPzc0FJojbLDNJpKtL0NIOgwgQViRCWkI?= =?Windows-1252?Q?+5YnDalOGHQDK2NKcMgBT3CnjuRHhP6hRpzBhtiDUmaCYMOLJGWpH+si?= =?Windows-1252?Q?RWfwym3I3+z/lh0+U34uNSCsTmMuiMkSlgM0w6VdpojeAoINqArnFJIH?= =?Windows-1252?Q?O48fJCAWR06307QJqmRKIwpwjTgKgH1gmxtFdxWhBQfxuhsHXGZ/aTF4?= =?Windows-1252?Q?ePlLb9EczrxsoXlvKdx5HiGaYeTKVW8wGVv2KnAJ6CfNaVIs3oqhSVwd?= =?Windows-1252?Q?BohPh/iuojMhS+3SvKvhFCH8gZcg3WU4zhm6zMjjRsQPLaizzJgFLhLD?= =?Windows-1252?Q?1WkSGx4yyEDjNZ9SfPND9fV6G7XsVYcEd8+EVqKpzSNrxK9KhJgLPsMa?= =?Windows-1252?Q?VL/9CW0PX/pVbuVu6GMkZQHTLCwriG0Wk/F408WksxKr7CRVVFIcHzi8?= =?Windows-1252?Q?3fDorR7ZBBwXBwvVGRsVKu+EhCmnG/qxwJlCtJJt4cceqq7InzSaYQt6?= =?Windows-1252?Q?csnu4cvN8JZ8ldJLuq37+z0gIpT/7ccfkzSL23tS9s3SPD/ipmfxS9rc?= =?Windows-1252?Q?mRQ6FwH8cInH+RXF0HMPNQfbuigtkX24Quk1XMPTEE8RMOIQqCGVWKuu?= =?Windows-1252?Q?p7gpI846dRmGUyLlECoCOE/HwHau7TqCLzVyt4DM4+3kAz6+kIqBXyIV?= =?Windows-1252?Q?yQ9gf1X5fMTpCE+U+o91cMBcEkXv4V2Ms5Er4Own/hCjSfA5NFIlsN3Y?= =?Windows-1252?Q?G5E7RwHXCWoq9iQ+tdeKmi2xVVHKM9o0=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1616;5:vij1avozfKd5+0KD5Gfi2EHexGCRPaZG2E1DM6QJ/4Q052X7+CiiI0m0ymmvlk5RbSul7OOqKwzPNju4oSVP67dtRNJT/7myFhLGy6iB/59kU749KD9cYlCJKWjQf0LTtR0T/eaHOSjNKHliy5jzNw==;24:yrygV9ycJ9ROy661xIhSCFu+oZ+75ZlK/VkUkbVX6w4T5s4XgqAfRWqyApjIZa6kC7u+PRGuiRQhCSu+t7vGuNVpWR4DOJrLfZT7V/3ApUg=;20:fR8Sw5Z/SGKmMBIpunqPFCfLevdUthLkXYgAlEaexhjEeDoy5dotHntS2Ca1sk8xrxgvpXloFmWl7I7Zm0vMqQHT3S/4fOSyWxSKmiSi9HHteWceLxhj3fWQxOs2EzmFKuaREnWBKief0rEozz/t7kest/z2Snd2bIb9E+R/fXNBFH6J+h2Gr8iYu4IvuE7Oqx6cwPoJN0LZz3v7bupteEy+Izhf51qrIlCPr7+bMgIJyDITD1wOhZqZ1tlRosfF SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2016 15:38:40.4208 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.174];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1616 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/16 19:36, David Miller wrote: > From: Santosh Shilimkar > Date: Sat, 20 Feb 2016 03:30:02 -0800 > >> @@ -54,6 +55,8 @@ module_param(rds_ib_mr_8k_pool_size, int, 0444); >> MODULE_PARM_DESC(rds_ib_mr_8k_pool_size, " Max number of 8K mr per HCA"); >> module_param(rds_ib_retry_count, int, 0444); >> MODULE_PARM_DESC(rds_ib_retry_count, " Number of hw retries before reporting an error"); >> +module_param(prefer_frmr, bool, 0444); >> +MODULE_PARM_DESC(prefer_frmr, "Preferred MR method if both FMR and FRMR supported"); > > Sorry, you're going to have to create a real run time method to configure > this parameter. > > I'm strongly against module parameters. > > Please don't go into details about why this might be difficult to do, > I'm totally not interested. Doing things properly is sometimes not > easy, that's life. Hello Santosh, What is the purpose of the prefer_frmr kernel module parameter ? Is this a parameter that is useful to RDS users or is its only purpose to allow developers of the RDS module to test both the FMR and FRMR code paths on hardware that supports both MR methods ? Bart.