From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756106AbcBWASf (ORCPT ); Mon, 22 Feb 2016 19:18:35 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:19469 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbcBWASc (ORCPT ); Mon, 22 Feb 2016 19:18:32 -0500 X-AuditID: cbfec7f5-f79b16d000005389-79-56cba5554c2a Subject: Re: [PATCH v2] ARM: dts: Move syscon reboot/poweroff to common dtsi for Exynos To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1455636348-14277-1-git-send-email-javier@osg.samsung.com> <56C3D745.7050904@samsung.com> <56C3D99C.3090403@osg.samsung.com> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Andi Shyti , Alim Akhtar , Kukjin Kim , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <56CBA551.4030205@samsung.com> Date: Tue, 23 Feb 2016 09:18:25 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <56C3D99C.3090403@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsVy+t/xK7qhS0+HGVycomPxYN42NovtR56x Wsw/co7V4s3bNUwWr18YWvQ/fs1ssenxNVaLy7vmsFnMOL+PyYHTY9OqTjaPzUvqPbb032X3 6NuyitHj8ya5ANYoLpuU1JzMstQifbsEroy+nk72gskCFRsmHGZrYDzJ08XIySEhYCJxpeEk O4QtJnHh3nq2LkYuDiGBpYwSm6euhXKeMkqcubyUGaRKWCBS4sbmy2C2iECoxL+LtxkhiroY JfpbroF1MAtcY5SY97EJbC6bgLHE5uVL2EBsXgEtie7Jz8BsFgFVif9/5zGB2KICERKHO7vY IWoEJX5MvscCYnMK6EscX/4LqJ4DaKiexP2LWiBhZgF5ic1r3jJPYBSYhaRjFkLVLCRVCxiZ VzGKppYmFxQnpeca6RUn5haX5qXrJefnbmKEhP3XHYxLj1kdYhTgYFTi4fXwOh0mxJpYVlyZ e4hRgoNZSYT32hSgEG9KYmVValF+fFFpTmrxIUZpDhYlcd6Zu96HCAmkJ5akZqemFqQWwWSZ ODilGhhVzfMvmbkZ3Jl9SdDy5KbYz+vcN2lfcHVNvdBsdCv/eeit1pfqe+9vNgjt/2l5rYYp WOVua+jRUzX3mlfE2z4ws3p0dVY2U4pywqRc7kcn956w4Q/avzXpo4Rz/V9j38Nxzk/23ghJ 3GhUl3MvdBentGyB/rsHn9+3r7NzmbLBtqPOv+HTrWIlluKMREMt5qLiRACOUh4LdwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.02.2016 11:23, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 02/16/2016 11:13 PM, Krzysztof Kozlowski wrote: > > [snip] > >>> diff --git a/arch/arm/boot/dts/exynos-syscon-restart.dtsi >>> b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >>> new file mode 100644 >>> index 000000000000..09a2040054ed >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/exynos-syscon-restart.dtsi >>> @@ -0,0 +1,27 @@ >>> +/* >>> + * Samsung's Exynos SoC syscon reboot/poweroff nodes common definition. >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License version 2 as >>> + * published by the Free Software Foundation. >>> + */ >>> + >>> +/ { >>> + soc { >>> + compatible = "simple-bus"; >> >> The exynos4 does not have soc node. I wonder whether we should provide >> here also address and size: >> #address-cells = <1>; >> #size-cells = <1>; >> ranges; >> >> Without this it works fine but that does not look correct enough. >> >> A minor effect of this patch on Exynos4 is that syscon-poweroff/reboot >> are now the only children of "soc" simple-bus (rest of platform devices >> is not)... but this is not a problem. >> >> Works fine so only the question about cells/ranges remains. Any comments? >> > > I in fact had the #address-cells and #size-cells at the beginning but then > realized that both the syscon-poweroff and syscon-reboot nodes didn't have > a reg property so it felt strange to me to have those. > > Also, I thought that maybe a SoC dtsi may need a different #address-cells > and #size-cells for the other child nodes so having those in this dtsi > could override the values in the SoC dtsi depending where is included. > > So I thought it could do more harm than good but I've no strong opinion > and can add those if you prefer. No comments from other people so I guess there are no objections. Applied for late v4.6. Best regards, Krzysztof