From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932627AbcBWH4x (ORCPT ); Tue, 23 Feb 2016 02:56:53 -0500 Received: from mail-bn1on0075.outbound.protection.outlook.com ([157.56.110.75]:13536 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752685AbcBWH4v (ORCPT ); Tue, 23 Feb 2016 02:56:51 -0500 Authentication-Results: spf=pass (sender IP is 137.71.25.55) smtp.mailfrom=analog.com; mail.ru; dkim=none (message not signed) header.d=none;mail.ru; dmarc=bestguesspass action=none header.from=analog.com; Reply-To: Subject: Re: [PATCH 07/61] gpio: adp5588: Use devm_gpiochip_add_data() for gpio registration References: <1456150130-2668-1-git-send-email-ldewangan@nvidia.com> <1456150130-2668-8-git-send-email-ldewangan@nvidia.com> To: Laxman Dewangan , , , , , , , , , CC: , , , , , , , , , , From: Michael Hennerich Organization: Analog Devices Inc. Message-ID: <56CC0F01.1000006@analog.com> Date: Tue, 23 Feb 2016 08:49:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456150130-2668-8-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD015;1:HR5K3Nqj6CEwqiTTokaOhoFXCPtsBQCy2M6wHBq4UNqnQTka4YotawKscO3vt48pDegkbbNCa6A4GGCIi65ziOQQoV+SjAxpgqp9Oa2Azi4NKtGmj9JzA0PmjM/xOQg7iAvpvBhvlpsTlP3fq2KyV/vunfQwZC9nDWpQdl5gOJrgmQuwNtuOuWtfndXPYAFGun4Acm4bETdOuOxRLsx7OawHShJtkQMH4coNkm0I5mXAdJWI9EC5st+jZPhorOXxnCwsuPa49pKvLMeMTOUKHa9DrzbfrLWk62DajS5Bc2T2QRLW8z0xCfW64PMvWYkPSVb2zZLrxmL/Y+cEdIYv9OyF9QRKSjJ8LkJhN+m50sm26N84iZwyoWsiBdXugSPh6RL3zh4u4Z6jCo/o0l/LR405XlNfgyhGUaa/WwKCqu0ICjlc7y1eDAh19F73oJ8RPmokUCjrcBVgoP3eQVFi54MBhKOHTsUnB983K/clar8Edxglxubsr9B7a2ib9baQ X-Forefront-Antispam-Report: CIP:137.71.25.55;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(377454003)(199003)(24454002)(479174004)(189002)(586003)(65956001)(1096002)(6806005)(33656002)(1220700001)(43066003)(5008740100001)(230700001)(2950100001)(64126003)(2906002)(77096005)(5001970100001)(4326007)(19580395003)(5001770100001)(3450700001)(83506001)(19580405001)(80316001)(53806999)(189998001)(23746002)(36756003)(2201001)(87936001)(47776003)(106466001)(65806001)(65816999)(76176999)(87266999)(54356999)(575784001)(86362001)(50986999)(59896002)(921003)(2101003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0301MB0766;H:nwd2mta1.analog.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 3be17d2a-1c9d-4bd9-ecda-08d33c26e0cb X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0766;2:an22r7BL0ysBIYSPb6ysIjTTuPqC437gP827jNBStHQvwSDvQ7QXN5BqcYd0zjb5atWaLt3L3UydbTXBCWZ73mQJgEenaq8TD4a1oHjzwIWbtglBMd2OVbHNST9YglMHLYXxkjFvEkNTnaKysWUnqZI8HFSMAnrAQxXGcLNGFZVGDoFi0ttgAajXPxHx1bnc;3:OKyOuoMh4D9DXm62c2mKhR+fGMmUiFjDpi7PNfGXUfsS+KlVTPo6sC2Tpk+vSMiiUlmsyPlZDdnFJdgK7HgFKinfoWslXv0NrlSo9u74VErhn9MTdPwjgm1ya/EvcpmbPUi/LUKu++Js2Y/VHRYhN5iA6n0+qKUt5CwjGMWXy8Kqdxwp3wo9psX7wlIw/Tg83ZaiefTLWQ5dbtYWYQzw9+ysckFVtHyl5C3v4+Sz/K3k5AaHXjsvpbBPw3CK6vAe9DFb5NPpArao16gC12HolQ==;25:UuJ0Wryf8+9wAM8bBwQc7Eqw9NS0wKfFOzAo/KCzK+11/vi14d0nqpWlAG781GOWgWqanhvXMz1hebC18blk4EvURLtzsSznm7AhWA5PLIUHgbLYXJi5MKTdD56nWv+j0nhlMhaoyo1K5Z/hgP6ySRP76vDNQRffX7FzIlBBd8DCY8mvzGsYMgY8RaBH0F7YyAZ7TmAQdDPjl9RX8ICSVqKWp3ADnadmWR8OEpZYJqqkyZDL26EleypiIqml7+As+s+0edJQz6+6XGzgUF/Bgtn43v1rnYOhRm5TZ9t9+XAaRdnva4oM5Fj6QJKBsdOgLW2qlI8GIyHwEwneZ3rFBZGnbo9xLaHAbVhf2F+73oo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DM2PR0301MB0766; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0766;20:rlfZITvETqnBnoASKIND/qMfjP4K8MpboCRbhqIMSBUqOU5Wp6vSQqN0MwFcb3+HrXfEOqo2ls0JS+44PX9LCIEe6kuHa8eL2G0kInR0LByIlv6jeka+uDwm1EvBsOkI+2nj8rIr+BGpd8NrgCufAstcCnPQFdoSHsqLkenfpbtgIcqP7nRpc2dKUJ/mfgJ12jQfUchiTJVym7QvgOveqK2UpHHkLhvrn8TYxKXEPu+tLgukmjZJWDm+NUNc1NPvwMSHWTDBpZV1PtDlydiWs8MytD33OQuoqqRoNA2zM5Rf9wQik8J4GZhApoKx1w/N6kpaEI+UB4duL3aZVorFgZYwUbWJCmHGiMaylrrA9n8zxXGj6ZCVW2GSFdnx8SAM1Rj626QdJAjwedzHD5gEYLgOlOc+vHgo4Zj5PV1ajNSrqEvAtjk+HEyaIuWdmLz0Z85J45if87phmm/JwYQCCAwHbkm2898EQvPBzU7ubXhuOfqgw1LHJiPXObq+Ipwt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13015025)(13023025)(13024025)(13017025)(13018025)(5005006)(10201501046)(3002001);SRVR:DM2PR0301MB0766;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0766; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0766;4:tCGZ1yN0NTTg/hQZbYCOhJRYJloAMV3G7V4fXeBaYZYNdhroKCmh9riYl9EEaWksmkFolo0i8nF9CmYHSPmh2U8Hq52kDnOyqmWxgU2k2dnaTYOIC4SgNEUkRgS4x8lU4NFcHvp+j63gYzmdh2F3l/Aj5OC91uskfzDOB4PyCSJCbAJK7RgcgCbbLMcQCmhpP8hOufsKcCI5d8u6tRYvgl9LgJfrD4ZcRYh4BRsXamfkeJzEaopBN5Y981aiBJwgM/Dgd3j/9TjOIpGNHxc8gUk4Eylu/kEJbyF0LOTx2g/sGlBHL8JpGLChM37YvQ96QWyn6g2PyhSVTU1JtRXFC9DxUe4KTkVopc4dyi4GiztWboT9p1C6SvpPkcKgNHRZmA6PSEaGvF6UDyihXt9L+6/9t5QnfTiuShrXpL/9AJj/rBmoMOt47Ti3m6U+t1DcrMuKcbhabCT7gzEjIHW7H/t1pSWIAt0Z7Fp3A6TJOVTga/dmdhWrD+ZNWy9S0WwY X-Forefront-PRVS: 08617F610C X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM2PR0301MB0766;23:FbNcb16CHoKxdsb24zhyjc/J6Z6xiVIhc3K?= =?Windows-1252?Q?uV129eclEamvkGjrz0KIJ9rQ1BD1IR/CnrYNWbXqtO+MhnqN29AGyuiM?= =?Windows-1252?Q?Fgm4lgvQij7leI5EFef32FWD9yl1wkWbSbmcf5A/4m9YUhKx38JBT3Iq?= =?Windows-1252?Q?ZiJb9HicubgtIEFny6SstUJz27HKehZv4zg2WJI01onUFPRhXQdyPvsp?= =?Windows-1252?Q?JPGeMpXiGnRd7FbBizoLJVBaGcAGfZ/aLd/Y42SUOrDzN8qK+/06KH89?= =?Windows-1252?Q?NKG4IU+T1xwEvfIwSLyOC0ak0t/kGllL+/Y1NPw/I8ocSX3BnNvGLx+n?= =?Windows-1252?Q?69b71glfr6F0simZeF5zzahYThA35gRNC6tS/YtWJ5VAdRkPOtBsPhYY?= =?Windows-1252?Q?7W/wQUr1KeB1JJVsDYngh7gpmArKbp5KehS+8gC3y748hQoygTtD0pVw?= =?Windows-1252?Q?xmiOb4WetHjK9gn4QCi8NkzA3n2/WWOuuBLq1GQ/yzTjdWOnpWdpRuIr?= =?Windows-1252?Q?QTuuHnx55HHZHLQUnDRyjIIneIPgcbJ4pqJtCMYQ1fGqIXdKjU+jN0nS?= =?Windows-1252?Q?pPb0SDloyHI98nxIQ8vuIY3TKYvkde7aqHspb+mV3WzIPf/6LZcvYyl8?= =?Windows-1252?Q?S0XRkl1IEIICeBfh9jffgd84JCyboS18sfuUx9pt8bhatO8rDlPfRAyw?= =?Windows-1252?Q?Yy+viL+STxGvEGqw1jEow8WQP1RptbpB8gb+bs2Pxdiwh/pBtpo9brAe?= =?Windows-1252?Q?45rVA2aZ1TiNY1+ZB5qaHAYPdQcLecYjwAezEDelrVx/piJJT/NQcOeE?= =?Windows-1252?Q?wdXXz/msFnHHoki8d6i3i5gmkUNfuVQfiyfPJbs59aFAHVrzVw0HKSZn?= =?Windows-1252?Q?hMa20yBhU2eLWlRCD7ZtRh7qw2wbleWdUP3f4YFN8JCmYcgTlu9v9DQk?= =?Windows-1252?Q?5Ir1StmgF6r0TRj4JNodXlvvc8DGNHH7x9pE3tgNGklAXPZnfWgQjBul?= =?Windows-1252?Q?GuqAxo2zJOg8pOcfr4uY644BJt6+Y9cuesbtMGYuSMTcDXCCF0QOm5Al?= =?Windows-1252?Q?Sb1zJoPTJ8NqNPbcCCeZJhLk18WRFgYJcMLN2nzdja9A1pBJRKybM4pb?= =?Windows-1252?Q?DRqMTYBOpK64jZ39M2mGf5rNhhmDPTHPTrMehtj1qUMzbilwfUMuzyze?= =?Windows-1252?Q?2vlv9yRabYqaWVRECbZnkNI6fyX6PzdP1cRBS2LWRhfOxy8WQoKIxYA4?= =?Windows-1252?Q?L9eYxk0l6TFUjC3bSfdlmHsqhUxLt4PgdLs30vx1WnsoO6T8fXKFvGOx?= =?Windows-1252?Q?Lfkofnm7KNJ8ym+IyYh4Qo+j+zpAdc90Dx6BBxMQCI8SGICs=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0766;5:DgcBfdsaqpQnSmTM20JrazvwsPkyuToMjH4oIWjaCMjvynaxsp/NMpiai+0s2MfkcRC0IndTNzA3DIjVwWVsjMKLoRJnBK8B5jwjm8H18yx0Q0l+87WA6eQdXDM6kUURrM2XxTrfoRnrpRebDHJF/g==;24:b9lrhL3mDLkhI/OahRohrtmTqxQbsXXzBmVINActhtsJtuZgwA7JWP1BJ3K0jPz4WKsHH8Z8GBAWxndXgSjSdFCe4D6WK9Zmv4ntOryYYqU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2016 07:56:46.6164 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0766 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2016 03:07 PM, Laxman Dewangan wrote: > Use devm_gpiochip_add_data() for GPIO registration and remove the > call for gpiochip_remove() from remove callback. > > Signed-off-by: Laxman Dewangan Acked-by: Michael Hennerich > Cc: Michael Hennerich > --- > drivers/gpio/gpio-adp5588.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c > index 19a0eba..c0f718b 100644 > --- a/drivers/gpio/gpio-adp5588.c > +++ b/drivers/gpio/gpio-adp5588.c > @@ -414,7 +414,7 @@ static int adp5588_gpio_probe(struct i2c_client *client, > } > } > > - ret = gpiochip_add_data(&dev->gpio_chip, dev); > + ret = devm_gpiochip_add_data(&client->dev, &dev->gpio_chip, dev); > if (ret) > goto err_irq; > > @@ -457,8 +457,6 @@ static int adp5588_gpio_remove(struct i2c_client *client) > if (dev->irq_base) > free_irq(dev->client->irq, dev); > > - gpiochip_remove(&dev->gpio_chip); > - > return 0; > } > > -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif