From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932667AbcBWH5Q (ORCPT ); Tue, 23 Feb 2016 02:57:16 -0500 Received: from mail-bl2on0089.outbound.protection.outlook.com ([65.55.169.89]:44112 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932326AbcBWH5O (ORCPT ); Tue, 23 Feb 2016 02:57:14 -0500 Authentication-Results: spf=pass (sender IP is 137.71.25.57) smtp.mailfrom=analog.com; mail.ru; dkim=none (message not signed) header.d=none;mail.ru; dmarc=bestguesspass action=none header.from=analog.com; Reply-To: Subject: Re: [PATCH 06/61] gpio: adp5520: Use devm_gpiochip_add_data() for gpio registration References: <1456150130-2668-1-git-send-email-ldewangan@nvidia.com> <1456150130-2668-7-git-send-email-ldewangan@nvidia.com> To: Laxman Dewangan , , , , , , , , , CC: , , , , , , , , , , From: Michael Hennerich Organization: Analog Devices Inc. Message-ID: <56CC0F1B.9040003@analog.com> Date: Tue, 23 Feb 2016 08:49:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456150130-2668-7-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD038;1:tC79aP0NqWsj8IKAQ/Frhg045xEEftMuNg0c3fIwihUrgHFpu++vqBv1r2SMIbLCfyY4fky7xKpWav2QBmI9IIbdfTwQ6nr502THJ2pgI9pipiewUEh5NiKUI78x8meqDXbln6lBmMv9zE4Qk4ZYMdt3MzChmFrZybJs7Ew8v+R7OP6W0K0xeACoNdZJdfwY6gINUiLs8N6Qjhm5FayN8yGI3KS/xrtg0qk9HKPROvek0c9XuokwS6W0lnbuSGcUA9AqO/cn/zfx6Kjv+EbnbjlAEaABHSEqarVBa6wpDAA9xy3/0wsyD96FLoi+1g3JLPLWRsXcYZGvQgf9redt7q/x+OL5QcB3tZAkZULe0/i6wvSmFYqaWB6rmfyPj8s2SH2pl8RHGcMSjepui+hZh+y/L7fL9+6bKKbLhwP+OTd1ICEl5ejLMpQByDR6rR+wcMbflsjNaJSj/O61PiVvHJlpEvfbq08BVAbcQittZtpVxJEcTv6d7/o5t/f2R1Co X-Forefront-Antispam-Report: CIP:137.71.25.57;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(199003)(479174004)(189002)(377454003)(87936001)(53806999)(50986999)(6806005)(87266999)(65816999)(76176999)(54356999)(23746002)(11100500001)(189998001)(5001970100001)(36756003)(2201001)(5008740100001)(47776003)(4326007)(65806001)(1096002)(230700001)(1220700001)(65956001)(586003)(59896002)(2906002)(3450700001)(83506001)(2950100001)(64126003)(86362001)(43066003)(33656002)(106466001)(80316001)(19580405001)(77096005)(19580395003)(5001770100001)(921003)(2101003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR0301MB0675;H:nwd2mta2.analog.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 09302b02-280d-4f48-f797-08d33c26ef97 X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0675;2:b2ymP3u5Gq3/k7CUKoXiwSrU0EDUZISmyA8izu4KhfPNZGeCFkxEpNaWlitW2mtRYvQjEQq0l5BbrhPkuEp5Fsdz3vn4qK5yX0KZB3hjQMFJdOoPZdemm6aUusTvKkp1T04kA1X99/CREdk28gYiM7JjdP7t1rSruIzVtZVy1GN3dFKbaPjz8UCRk5+4UYvM;3:rO0pt0qmumFILe0NjIlBuUP0yoh1EEozOl7JGDhB3D31iwty0hT6FNkwSlJXk67/IXRYmYx+mGx5rAtVVbDC60ZPxv6jL793Oo4j90pbhGzT7JVd9AC2gnHuEATmsVTr2HJiBbRwlEvNA7OAVYV4LcXj7MUIv8bqjqX13fS7AP20RwcKF5u+aLGyP0/wXQGvDLRjtuKx/EopKdZyFWPOrsqLkY0Q1d+bXLN7WL/rTVLWY1U69YwF4rFcB82/Vk64SHRw93Dw18pkfj8iD6i6DQ==;25:/7YH3LrWuucofU500eBdGW152bUQ3jXxwkUed9VCJ9yqqJy2BV2zIE7YfYSwxY2Cn9VWhKeprSUjve/83P0Il/7E4sbJkuVeQivBWj2blp0ZLd/8qJFUYgPSpb4ixNqkWfZNNd/7byUt5MJWoNUkvEhpbyqYQcF5oEV6sHVWJ4/Ypbm1iX1fhHUqRTbKJjS836jKFEilK0gpveZQh1OTrAuPAPr22BOAochOCgreRMsl+C8sLhDVlGv2cAx+/XAZx4BZExMnj5cFfPu5+vi0CKzzlJi48kEwdqX0DVY4GWcXdP06i2RTTivW9lSgO7TOjcmhh8SBrwPmwhJnXvyhMY1Sol0yGvaoBFLXwfkeODA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BN1PR0301MB0675; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0675;20:3iw05XOvuXYWACdWZkBIkCOeB6dWIqHvUQJHT0M4nT7w1Mz7qnPkOhc/HzQFOeNDGj0iNWvJT5lMkvW5il4Iieo7PAv8O5ssIDched8ooB4fTo8XsouCIiIZnEY5wO9+bEu8tg6t+PwnZxC2rUUo2T8SpCKfiZwTK36qm305f4IBnIN1ylGFxvPkU1URx6LsvjlyqtmTz1n4IpXMM4eBkntu9Px5IPBdacRJUx6azwb/7tJ+yL1rViQ8O2cacrJe8lBowN1WLKIgj7nW+UycAtAQdtxzj5T6onmCT0TemkdiP9X4z/Q4I+v9KzAfrBXT6MRwM5Wtfwwy1l3iitFHFUy71uoz911KVjnJaFKqAnslWuw4P6pVWjU71BOrn6sgfbGLd0wWsae/Tm3MJ/UHgesoCGVQ6W8b01uDVa0kr72mh8UZhAuvN67oopzFSf/NaslTd7FZIwRKmdkJiAHSV+CwbDjGdPnN0ymqCJXIYE4wnS97yPYOlDdhJuWDdsUD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(8121501046)(13015025)(13023025)(13024025)(13018025)(5005006)(10201501046)(3002001);SRVR:BN1PR0301MB0675;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0675; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0675;4:wLVNAu417kYPetFcv8smHK87+PGmlOFuY0rOhOYZ3r6C/p1nSOqvXUzjUmEuKNsGrVcBjzrs1neXyVRysJSbsFoEPjvZifjVyBPomTaGHsJnyvfL63zp79p5JqP1fUzhug0wFdNg0QkhAUN85c8Zo12Fm/GTSKLeOL1/XTHDk/unGdhAZ/B19aF74Ew2/1Z/tyXZ6C7M4c+FRTFnQtl0eBsrEoXwxugG/rOABmRsBfKbp2Kwqa0KP08Enn5dcszU9t5du/75S8Fkm1vIEM1BQjBZcNAvzRkAiQXbP8v3q69pi+8Mx4kppvlr3LUhTg1mlP4qnA/47gtWkBqf8MgV8QAwwIpxhHZ/u8E30psOMTdiWpwEh7Zp1VwyIZ29/VSFMXnYn2TZHzYBL9b365X0QUfnhChk8xahwZTsdbk8jqT8QyckB2jxyjxrS/DYd8v+TF4YK9S9QcLiIeOpeQJCyyJbcvgnbnef/vXUWqx+RU5DpEXtwc0R9Xjn4jLXOcxd X-Forefront-PRVS: 08617F610C X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1PR0301MB0675;23:8drhNNSJM4OCcCLqwGuw64lATwdhdrvKE8Z?= =?Windows-1252?Q?972BFORMTtfyLSb+1Wv534KqSSJzaqbuhyyetXdro9+YkmwS44L5O9ZY?= =?Windows-1252?Q?bOWbBTT5ofohzaPzBb2dz42cSUpEOGrk+j8WOO5QmgtNwUq3a8gd888T?= =?Windows-1252?Q?G+oEa5iTYujKzI6YDlRfLdS7iLzb0N6nQOzXpvImHNn0dYh3iPHlJ7tK?= =?Windows-1252?Q?Toamcoq868mETXdJxmXTc7htfv7kgCFL+BWHmVbDeGW7dP32aIUviU01?= =?Windows-1252?Q?+hfqf5We4xbfyvnlrVnGeV4QvwxgV0tbzaLANWmoVPUrTPr4SgYB4U+5?= =?Windows-1252?Q?4GwVSsD6Q0+ZqtLby1+KXoPi6iUaLpwWrnW2q2kHzTsrjhcpQCffLGEm?= =?Windows-1252?Q?vVKi85WD9r3P616KYSZnmLUGBMyWlOd9VwPlHPqGaBeSXmuFukrdqxsK?= =?Windows-1252?Q?glc4auGIaU31Z3md7JEIyRETWJugin3w67h0svMNdxbOqDh8HBfYq5u3?= =?Windows-1252?Q?YTr4/YnNyz+RtqLxKzi5G86uvDhB/ZgXegmYQjsN1IfcwqeDcwVBLFVH?= =?Windows-1252?Q?zVebPG7RNaDLxkF73VbFhyZYmfbid+dJtlYDpCc22bZJyFb7P0jf7tMT?= =?Windows-1252?Q?8aCsXODUx4hOmHjvU1n+LyaPA7rph55GdBDFhC0tNCeU0F+Iit5FGtlu?= =?Windows-1252?Q?6ULGNzU15frXyhjfLCmvOZ6V+jMlbAxZvJYIbvRJP7Eckv6DL0bCFcYH?= =?Windows-1252?Q?7LPSl6T9faMXr1AbFALDIpYsuHFU0uWeqqTXDVTAZbM9lZaW9zfxIQNg?= =?Windows-1252?Q?9N0aUY35VrKkg/GQxb3bOQSG1YbmVBBlrg9a+JzDo4klF17Wga5smbLs?= =?Windows-1252?Q?i8/3/DPwqTcxGyj5SJjhMO3P/ol0Yo0lav+a7zGIys3TL9yHn/bZe5bg?= =?Windows-1252?Q?EiLcmUULW6JDDouE+RQoHzpEaUb3Q2JhkIrnXqt1x2GyI51RSmC4PKAX?= =?Windows-1252?Q?dTVRsj/XQsYLwB+5f6xh8VaQsh/TChmfIRTqQR+qoYtg/kInEd16dfyY?= =?Windows-1252?Q?7fOwws3RJqk9I223jRbuO8vXXxNpFJ4RAXESkdRT4sO80t3QjoYGV/NR?= =?Windows-1252?Q?JC1Pf7lBh8fzGm6FFExsTUevhp55BtbFVOI410hVtjXjVDgsGFZyF6c3?= =?Windows-1252?Q?8i+qtwEsQ4ks+D6UiBY0MudIarJdpeC0RAdJe9yBOGXc2/DA+/4DgHcs?= =?Windows-1252?Q?H2miQJSflj4I6I+meO+5HKCNx6/w46Rfd+D8vpPh++U0T0Anbq9C8D8q?= =?Windows-1252?Q?uYTa0nsaByaQS8251u9wraw9oEef8NkcSabcP3yxJzzHqnSk=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0675;5:EQUaiW3aEaxEU+HL5zBKhfXX5mCxXjDTk6evbaEbQxlswHKsAUX1FwIs5VykejwkG7wYWlqicQ4Z7Hhr36Quc8FbKLjV6mZiFeUnhEqhOVms9Pbalt3UYUx/a5IWIKkzUjD+FycdKLo/ujilA5SEGA==;24:nAKbj79cqALuL+DoLu211068+IwSsAw+O0iRRZW2MFCysXbUfZgbrGgT86O8jBiFoZiU8iNSXxjgmdpUgyy9VslvX0lgdSw2ieG9/onCS/w= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2016 07:57:11.4417 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0675 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2016 03:07 PM, Laxman Dewangan wrote: > Use devm_gpiochip_add_data() for GPIO registration and remove the > call for gpiochip_remove() from error path. > > Also remove the need of driver callback .remove. > > Signed-off-by: Laxman Dewangan Acked-by: Michael Hennerich > Cc: Michael Hennerich > --- > drivers/gpio/gpio-adp5520.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/gpio/gpio-adp5520.c b/drivers/gpio/gpio-adp5520.c > index 4fa7ff1..abf1996 100644 > --- a/drivers/gpio/gpio-adp5520.c > +++ b/drivers/gpio/gpio-adp5520.c > @@ -153,7 +153,7 @@ static int adp5520_gpio_probe(struct platform_device *pdev) > goto err; > } > > - ret = gpiochip_add_data(&dev->gpio_chip, dev); > + ret = devm_gpiochip_add_data(&pdev->dev, &dev->gpio_chip, dev); > if (ret) > goto err; > > @@ -164,22 +164,11 @@ err: > return ret; > } > > -static int adp5520_gpio_remove(struct platform_device *pdev) > -{ > - struct adp5520_gpio *dev; > - > - dev = platform_get_drvdata(pdev); > - gpiochip_remove(&dev->gpio_chip); > - > - return 0; > -} > - > static struct platform_driver adp5520_gpio_driver = { > .driver = { > .name = "adp5520-gpio", > }, > .probe = adp5520_gpio_probe, > - .remove = adp5520_gpio_remove, > }; > > module_platform_driver(adp5520_gpio_driver); > -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif