From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751374AbcBWKNV (ORCPT ); Tue, 23 Feb 2016 05:13:21 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36752 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbcBWKNR (ORCPT ); Tue, 23 Feb 2016 05:13:17 -0500 Subject: Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period To: Shreyas B Prabhu References: <1455637383-14412-1-git-send-email-daniel.lezcano@linaro.org> <1455637383-14412-2-git-send-email-daniel.lezcano@linaro.org> <56CC2F38.5070507@linux.vnet.ibm.com> Cc: tglx@linutronix.de, peterz@infradead.org, rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nicolas.pitre@linaro.org, vincent.guittot@linaro.org From: Daniel Lezcano Message-ID: <56CC30B7.8090304@linaro.org> Date: Tue, 23 Feb 2016 11:13:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56CC2F38.5070507@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2016 11:06 AM, Shreyas B Prabhu wrote: > > > On 02/16/2016 09:13 PM, Daniel Lezcano wrote: > [...] >> + if (index < 0) { >> + /* >> + * No idle callbacks fulfilled the constraints, jump >> + * to the default function like there wasn't any >> + * cpuidle driver. >> + */ >> + goto default_idle; >> + } else { >> + /* >> + * Enter the idle state previously returned by the >> + * governor decision. This function will block until >> + * an interrupt occurs and will take care of >> + * re-enabling the local interrupts >> + */ >> + return cpuidle_enter(drv, dev, index); > > Minor point. You are not calling rcu_idle_exit() in else block. This > should probably be > ret = cpuidle_enter(drv, dev, index); > goto out; Yes. Right. Thanks for the review. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog