From: Ian Abbott <abbotti@mev.co.uk>
To: Joe Perches <joe@perches.com>,
Philippe Loctaux <phil@philippeloctaux.com>,
gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: mite: added spaces around | and *
Date: Tue, 23 Feb 2016 11:07:15 +0000 [thread overview]
Message-ID: <56CC3D63.60706@mev.co.uk> (raw)
In-Reply-To: <1456187828.4139.3.camel@perches.com>
On 23/02/16 00:37, Joe Perches wrote:
> On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote:
>> Added spaces around | and *, fixing 2 checkpatch checks.
> []
>> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> []
>> @@ -51,7 +51,7 @@
>>
>> #include "mite.h"
>>
>> -#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK)))
>> +#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK)))
>
> It'd be nice to remove superfluous parentheses here too
>
> +#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)
>
Even better: just remove the macro, as it isn't used.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2016-02-23 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 23:38 [PATCH] Staging: comedi: mite: added spaces around | and * Philippe Loctaux
2016-02-23 0:37 ` Joe Perches
2016-02-23 11:07 ` Ian Abbott [this message]
2016-02-23 12:38 ` Philippe Loctaux
2016-02-23 16:39 ` Ian Abbott
2016-02-23 16:48 ` Ian Abbott
2016-02-23 21:47 ` Philippe Loctaux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC3D63.60706@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@philippeloctaux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).