From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751241AbcBWL5V (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 06:57:21 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:15730 "EHLO
	SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750737AbcBWL5U (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 06:57:20 -0500
X-IronPort-AV: E=Sophos;i="5.22,489,1449532800"; 
   d="scan'208";a="340188331"
Subject: Re: [Xen-devel] [PATCH v3 10/11] x86/rtc: replace paravirt rtc check
 with x86 specific solution
To: "Luis R. Rodriguez" <mcgrof@kernel.org>, <bp@alien8.de>, <hpa@zytor.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <rusty@rustcorp.com.au>
References: <1456212255-23959-1-git-send-email-mcgrof@kernel.org>
 <1456212255-23959-11-git-send-email-mcgrof@kernel.org>
CC: <xen-devel@lists.xensource.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <luto@amacapital.net>,
        <lguest@lists.ozlabs.org>, <david.vrabel@citrix.com>,
        <boris.ostrovsky@oracle.com>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <56CC491C.8080505@citrix.com>
Date: Tue, 23 Feb 2016 11:57:16 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1456212255-23959-11-git-send-email-mcgrof@kernel.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23/02/16 07:24, Luis R. Rodriguez wrote:
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
[...]
> @@ -1526,8 +1525,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  
>  	/* Install Xen paravirt ops */
>  	pv_info = xen_info;
> -	if (xen_initial_domain())
> -		pv_info.features |= PV_SUPPORTED_RTC;
>  	pv_init_ops = xen_init_ops;
>  	if (!xen_pvh_domain()) {
>  		pv_cpu_ops = xen_cpu_ops;
> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> index a0a4e554c6f1..fbfcb01015f0 100644
> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -446,8 +446,10 @@ void __init xen_init_time_ops(void)
>  	x86_platform.calibrate_tsc = xen_tsc_khz;
>  	x86_platform.get_wallclock = xen_get_wallclock;
>  	/* Dom0 uses the native method to set the hardware RTC. */
> -	if (!xen_initial_domain())
> +	if (!xen_initial_domain()) {
> +		x86_init.platform_flags |= X86_PLATFORM_NO_RTC;
>  		x86_platform.set_wallclock = xen_set_wallclock;
> +	}
>  }

Is this an early enough point to set this flag?

David