From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753574AbcBWPKs (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 10:10:48 -0500
Received: from hqemgate15.nvidia.com ([216.228.121.64]:4100 "EHLO
	hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752508AbcBWPKp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 10:10:45 -0500
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Tue, 23 Feb 2016 07:09:40 -0800
Message-ID: <56CC7390.6050805@nvidia.com>
Date: Tue, 23 Feb 2016 20:28:24 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Alban <albeu@free.fr>
CC: <linus.walleij@linaro.org>, <gnurou@gmail.com>,
        <michael.hennerich@analog.com>, <corbet@lwn.net>, <rjui@broadcom.com>,
        <shc_work@mail.ru>, <support.opensource@diasemi.com>,
        <swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
        <bjorn.andersson@sonymobile.com>, <a.kesavan@samsung.com>,
        <gregkh@linuxfoundation.org>, <catalin.marinas@arm.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <patches@opensource.wolfsonmicro.com>,
        <bcm-kernel-feedback-list@broadcom.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for gpio
 registration
References: <1456150130-2668-1-git-send-email-ldewangan@nvidia.com>	<1456150130-2668-11-git-send-email-ldewangan@nvidia.com> <20160222211323.5c10533f@tock>
In-Reply-To: <20160222211323.5c10533f@tock>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Tuesday 23 February 2016 01:43 AM, Alban wrote:
> On Mon, 22 Feb 2016 19:37:59 +0530
> Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> Use devm_gpiochip_add_data() for GPIO registration.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Cc: Alban Bedel <albeu@free.fr>
>> ---
>>   drivers/gpio/gpio-ath79.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
>> index d13dd13..a6aad59 100644
>> --- a/drivers/gpio/gpio-ath79.c
>> +++ b/drivers/gpio/gpio-ath79.c
>> @@ -182,7 +182,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>>   		ctrl->chip.direction_output = ar934x_gpio_direction_output;
>>   	}
>>   
>> -	err = gpiochip_add_data(&ctrl->chip, ctrl);
>> +	err = devm_gpiochip_add_data(&pdev->dev, &ctrl->chip, ctrl);
>>   	if (err) {
>>   		dev_err(&pdev->dev,
>>   			"cannot add AR71xx GPIO chip, error=%d", err);
> With the patches already applied to the devel branch a few more changes
> will be needed to remove the calls to gpiochip_remove() in the probe
> error path and the remove callback.
>
OK, I will drop this patch when provide the git pointer to Linus.
We can work on this later.