From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbcBWQAP (ORCPT ); Tue, 23 Feb 2016 11:00:15 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34421 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbcBWQAN (ORCPT ); Tue, 23 Feb 2016 11:00:13 -0500 Subject: Re: [PATCH] tty: audit: remove unused variable To: Sudip Mukherjee , Greg Kroah-Hartman , Jiri Slaby References: <1456216211-23509-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: linux-kernel@vger.kernel.org From: Peter Hurley Message-ID: <56CC8208.9020804@hurleysoftware.com> Date: Tue, 23 Feb 2016 08:00:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456216211-23509-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudip, On 02/23/2016 12:30 AM, Sudip Mukherjee wrote: > While building with W=1 we were getting build warning: > drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used > > The local variable sessionid was only assigned the value of > current->sessionid but was never reused. Thanks for catching this. While reviewing this patch, I noticed entire if clause can be reduced to if (audit_enabled) tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1); since auid is unused variable as well. Regards, Peter Hurley > Signed-off-by: Sudip Mukherjee > --- > drivers/tty/tty_audit.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c > index 66d53fc..81fe3fb 100644 > --- a/drivers/tty/tty_audit.c > +++ b/drivers/tty/tty_audit.c > @@ -146,10 +146,8 @@ void tty_audit_tiocsti(struct tty_struct *tty, char ch) > > if (audit_enabled) { > kuid_t auid; > - unsigned int sessionid; > > auid = audit_get_loginuid(current); > - sessionid = audit_get_sessionid(current); > tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1); > } > } >