From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754665AbcBWRfj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 12:35:39 -0500
Received: from exsmtp03.microchip.com ([198.175.253.49]:12735 "EHLO
	email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1754052AbcBWRfi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 12:35:38 -0500
Subject: Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
References: <1455905390-3491-2-git-send-email-joshua.henderson@microchip.com>
 <20160219181712.GD2222@piout.net>
CC: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Alessandro Zummo <a.zummo@towertech.it>, <rtc-linux@googlegroups.com>
From: Joshua Henderson <joshua.henderson@microchip.com>
Message-ID: <56CC9894.7000307@microchip.com>
Date: Tue, 23 Feb 2016 10:36:20 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160219181712.GD2222@piout.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alexandre,

On 02/19/2016 11:17 AM, Alexandre Belloni wrote:
> Hi,
> 
> On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote :
>> This driver adds support for the PIC32 real time clock and calendar
>> peripheral:
>> 	- reading and setting time
>> 	- alarms when connected to an IRQ
> 
> Just for confirmation, your probe() fails hard when there are no IRQ
> specified or the IRQ request fails.
> 
> I'll review later but if that the only thing, I can fix it up when
> applying, no need to resend.
> 

probe() does indeed fail when no interrupt is specified:

  ...
  pic32-rtc 1f8c0000.rtc: no irq for alarm
  ...
  hctosys: unable to open rtc device (rtc0)
  ...

If I'm following, I think there right answer here is to just change the wording
in the commit message to be clear that the interrupt is not conditional.  It's
required via binding.  This peripheral has a dedicated interrupt and I can't
imagine a case where it makes sense not to specify it.

I'm fine with something like "- alarms provided by dedicated interrupt" as a
replacement.

Josh