From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756886AbcBXEAm (ORCPT ); Tue, 23 Feb 2016 23:00:42 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:34605 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756491AbcBXEAi (ORCPT ); Tue, 23 Feb 2016 23:00:38 -0500 Subject: Re: [PATCH] usb: dwc2: Use kmem_cache_free() To: Amitoj Kaur Chawla , "John.Youn@synopsys.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Felipe Balbi References: <20160222081032.GA9818@amitoj-Inspiron-3542> CC: "julia.lawall@lip6.fr" From: John Youn Message-ID: <56CD2A8F.2060709@synopsys.com> Date: Tue, 23 Feb 2016 19:59:11 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160222081032.GA9818@amitoj-Inspiron-3542> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.96] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/22/2016 12:11 AM, Amitoj Kaur Chawla wrote: > Here, free memory is allocated using kmem_cache_zalloc. So, use > kmem_cache_free instead of kfree. > > This is done using Coccinelle and semantic patch used > is as follows: > > // > @@ > expression x,E,c; > @@ > x = > \(kmem_cache_alloc\|kmem_cache_zalloc\|kmem_cache_alloc_node\)(c,...) > ... when != x = E > when != &x > ?-kfree(x) > +kmem_cache_free(c,x) > // > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/usb/dwc2/hcd_ddma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/hcd_ddma.c b/drivers/usb/dwc2/hcd_ddma.c > index 36606fc..d6ebd16 100644 > --- a/drivers/usb/dwc2/hcd_ddma.c > +++ b/drivers/usb/dwc2/hcd_ddma.c > @@ -111,7 +111,7 @@ static int dwc2_desc_list_alloc(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, > dma_unmap_single(hsotg->dev, qh->desc_list_dma, > qh->desc_list_sz, > DMA_FROM_DEVICE); > - kfree(qh->desc_list); > + kmem_cache_free(desc_cache, qh->desc_list); > qh->desc_list = NULL; > return -ENOMEM; > } > Acked-by: John Youn John