From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, kai.huang@linux.intel.com,
jike.song@intel.com
Subject: Re: [PATCH v4 00/11] KVM: x86: track guest page access
Date: Wed, 24 Feb 2016 14:42:06 +0100 [thread overview]
Message-ID: <56CDB32E.60306@redhat.com> (raw)
In-Reply-To: <1456307476-46398-1-git-send-email-guangrong.xiao@linux.intel.com>
On 24/02/2016 10:51, Xiao Guangrong wrote:
> Changelog in v4:
> thanks to Paolo's review, the changes in this version are:
> - comment struct kvm_mmu_page_role to explain the rule bits used by indirect
> shadow page can not be more than 15 bits
> - simplify overflow detection of track count
> - remove the wrap functions, kvm_page_track_{add,remove}_page
> - rename kvm_slot_page_track_*_nolock to kvm_slot_page_track_*
> - rename the function, check_mode, to page_track_mode_is_valid and inline it
> - rename kvm_page_track_check_mode to kvm_page_track_is_active
> - check if the notifier list is empty before holding the srcu lock
> - move the patch adjusting write-flooding more earlier
Looks good, thanks!
Paolo
prev parent reply other threads:[~2016-02-24 13:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 9:51 [PATCH v4 00/11] KVM: x86: track guest page access Xiao Guangrong
2016-02-24 9:51 ` [PATCH 01/11] KVM: MMU: rename has_wrprotected_page to mmu_gfn_lpage_is_disallowed Xiao Guangrong
2016-02-24 9:51 ` [PATCH 02/11] KVM: MMU: introduce kvm_mmu_gfn_{allow,disallow}_lpage Xiao Guangrong
2016-02-24 9:51 ` [PATCH 03/11] KVM: MMU: introduce kvm_mmu_slot_gfn_write_protect Xiao Guangrong
2016-02-24 9:51 ` [PATCH 04/11] KVM: page track: add the framework of guest page tracking Xiao Guangrong
2016-02-24 9:51 ` [PATCH 05/11] KVM: page track: introduce kvm_slot_page_track_{add,remove}_page Xiao Guangrong
2016-02-24 9:51 ` [PATCH 06/11] KVM: MMU: let page fault handler be aware tracked page Xiao Guangrong
2016-02-24 9:51 ` [PATCH 07/11] KVM: MMU: clear write-flooding on the fast path of " Xiao Guangrong
2016-02-24 9:51 ` [PATCH 08/11] KVM: page track: add notifier support Xiao Guangrong
2016-02-24 9:51 ` [PATCH 09/11] KVM: MMU: use page track for non-leaf shadow pages Xiao Guangrong
2016-02-29 15:22 ` Paolo Bonzini
2016-02-24 9:51 ` [PATCH 10/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong
2016-02-24 9:51 ` [PATCH 11/11] KVM: MMU: apply page track notifier Xiao Guangrong
2016-02-24 13:42 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDB32E.60306@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=jike.song@intel.com \
--cc=kai.huang@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox