From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757602AbcBXNmP (ORCPT ); Wed, 24 Feb 2016 08:42:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35735 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbcBXNmL (ORCPT ); Wed, 24 Feb 2016 08:42:11 -0500 Subject: Re: [PATCH v4 00/11] KVM: x86: track guest page access To: Xiao Guangrong References: <1456307476-46398-1-git-send-email-guangrong.xiao@linux.intel.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kai.huang@linux.intel.com, jike.song@intel.com From: Paolo Bonzini Message-ID: <56CDB32E.60306@redhat.com> Date: Wed, 24 Feb 2016 14:42:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1456307476-46398-1-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/02/2016 10:51, Xiao Guangrong wrote: > Changelog in v4: > thanks to Paolo's review, the changes in this version are: > - comment struct kvm_mmu_page_role to explain the rule bits used by indirect > shadow page can not be more than 15 bits > - simplify overflow detection of track count > - remove the wrap functions, kvm_page_track_{add,remove}_page > - rename kvm_slot_page_track_*_nolock to kvm_slot_page_track_* > - rename the function, check_mode, to page_track_mode_is_valid and inline it > - rename kvm_page_track_check_mode to kvm_page_track_is_active > - check if the notifier list is empty before holding the srcu lock > - move the patch adjusting write-flooding more earlier Looks good, thanks! Paolo