From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
<konrad.wilk@oracle.com>
Cc: <xen-devel@lists.xenproject.org>, <mcgrof@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/x86: Zero out .bss for PV guests
Date: Wed, 24 Feb 2016 14:58:40 +0000 [thread overview]
Message-ID: <56CDC520.1000609@citrix.com> (raw)
In-Reply-To: <56CDC39B.3060004@oracle.com>
On 24/02/16 14:52, Boris Ostrovsky wrote:
> On 02/24/2016 09:15 AM, Andrew Cooper wrote:
>> On 24/02/16 14:12, David Vrabel wrote:
>>> On 22/02/16 22:06, Boris Ostrovsky wrote:
>>>> Baremetal kernels clear .bss early in the boot. Since Xen PV guests
>>>> don't
>>>> excecute that early code they should do it too.
>>>>
>>>> (Since we introduce macros for specifying 32- and 64-bit registers we
>>>> can get rid of ifdefs in startup_xen())
>>> .bss must have been cleared for PV guests otherwise they would be
>>> horribly broken. What was the method and why is it no longer
>>> sufficient?
>
> I couldn't find this being done anywhere, hence this patch.
>
>> The domain builder hands out zeroed pages. I don't believe we guarantee
>> that the guests RAM is clean, but it is in practice.
>
> OK, that's what I suspected but didn't actually look.
>
> I, in fact, wonder whether this should go to stable trees as well.
Yes. Can you respin with a commit message explaining? (Or just provide
the message here and I'll fix it up).
David
next prev parent reply other threads:[~2016-02-24 14:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 22:06 [PATCH] xen/x86: Zero out .bss for PV guests Boris Ostrovsky
2016-02-24 14:12 ` [Xen-devel] " David Vrabel
2016-02-24 14:15 ` Andrew Cooper
2016-02-24 14:52 ` Boris Ostrovsky
2016-02-24 14:58 ` David Vrabel [this message]
2016-02-24 16:22 ` Luis R. Rodriguez
2016-02-24 16:46 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDC520.1000609@citrix.com \
--to=david.vrabel@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox