From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756118AbcBXO65 (ORCPT ); Wed, 24 Feb 2016 09:58:57 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33593 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390AbcBXO6z (ORCPT ); Wed, 24 Feb 2016 09:58:55 -0500 Message-ID: <56CDC52B.1040407@electrozaur.com> Date: Wed, 24 Feb 2016 16:58:51 +0200 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sudip Mukherjee , Benny Halevy , "Martin K. Petersen" , James Bottomley CC: linux-kernel@vger.kernel.org, osd-dev@open-osd.org, linux-scsi@vger.kernel.org, Joe Perches Subject: Re: [PATCH v2] osd: remove deadcode References: <1456312888-22074-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1456312888-22074-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2016 01:21 PM, Sudip Mukherjee wrote: > The variable is_ver1 is always true and so OSD_CAP_LEN can never be > used. > Reported by Coverity. > > Signed-off-by: Sudip Mukherjee ACK-by: Boaz harrosh Thanks > --- > > v2: Joe Perches asked to mention the tool used in the commit log. > > drivers/scsi/osd/osd_initiator.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c > index d8a2b51..3b11aad 100644 > --- a/drivers/scsi/osd/osd_initiator.c > +++ b/drivers/scsi/osd/osd_initiator.c > @@ -2006,9 +2006,8 @@ EXPORT_SYMBOL(osd_sec_init_nosec_doall_caps); > */ > void osd_set_caps(struct osd_cdb *cdb, const void *caps) > { > - bool is_ver1 = true; > /* NOTE: They start at same address */ > - memcpy(&cdb->v1.caps, caps, is_ver1 ? OSDv1_CAP_LEN : OSD_CAP_LEN); > + memcpy(&cdb->v1.caps, caps, OSDv1_CAP_LEN); > } > > bool osd_is_sec_alldata(struct osd_security_parameters *sec_parms __unused) >