From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755573AbcBXPaI (ORCPT ); Wed, 24 Feb 2016 10:30:08 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:58276 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbcBXPaG (ORCPT ); Wed, 24 Feb 2016 10:30:06 -0500 Subject: Re: [PATCH] watchdog: orion: Depend on 32-bit ARM To: Thierry Reding , Wim Van Sebroeck References: <1456323726-20234-1-git-send-email-thierry.reding@gmail.com> Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <56CDCC77.9040709@roeck-us.net> Date: Wed, 24 Feb 2016 07:29:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456323726-20234-1-git-send-email-thierry.reding@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2016 06:22 AM, Thierry Reding wrote: > From: Thierry Reding > > The driver uses the atomic_io_modify() function to update registers, but > that function is only available on 32-bit ARM. Recent changes have added > ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build > on 64-bit ARM where this function isn't available and thereby causing > allmodconfig builds to break. > > Signed-off-by: Thierry Reding Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 9289da313d98..cfec157488b1 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG > config ORION_WATCHDOG > tristate "Orion watchdog" > depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU > + depends on ARM > select WATCHDOG_CORE > help > Say Y here if to include support for the watchdog timer >