* [PATCH] watchdog: orion: Depend on 32-bit ARM
@ 2016-02-24 14:22 Thierry Reding
2016-02-24 15:29 ` Guenter Roeck
2016-03-04 19:37 ` Wim Van Sebroeck
0 siblings, 2 replies; 3+ messages in thread
From: Thierry Reding @ 2016-02-24 14:22 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck; +Cc: linux-watchdog, linux-kernel
From: Thierry Reding <treding@nvidia.com>
The driver uses the atomic_io_modify() function to update registers, but
that function is only available on 32-bit ARM. Recent changes have added
ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build
on 64-bit ARM where this function isn't available and thereby causing
allmodconfig builds to break.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 9289da313d98..cfec157488b1 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG
config ORION_WATCHDOG
tristate "Orion watchdog"
depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
+ depends on ARM
select WATCHDOG_CORE
help
Say Y here if to include support for the watchdog timer
--
2.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: orion: Depend on 32-bit ARM
2016-02-24 14:22 [PATCH] watchdog: orion: Depend on 32-bit ARM Thierry Reding
@ 2016-02-24 15:29 ` Guenter Roeck
2016-03-04 19:37 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2016-02-24 15:29 UTC (permalink / raw)
To: Thierry Reding, Wim Van Sebroeck; +Cc: linux-watchdog, linux-kernel
On 02/24/2016 06:22 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The driver uses the atomic_io_modify() function to update registers, but
> that function is only available on 32-bit ARM. Recent changes have added
> ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build
> on 64-bit ARM where this function isn't available and thereby causing
> allmodconfig builds to break.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9289da313d98..cfec157488b1 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG
> config ORION_WATCHDOG
> tristate "Orion watchdog"
> depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
> + depends on ARM
> select WATCHDOG_CORE
> help
> Say Y here if to include support for the watchdog timer
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: orion: Depend on 32-bit ARM
2016-02-24 14:22 [PATCH] watchdog: orion: Depend on 32-bit ARM Thierry Reding
2016-02-24 15:29 ` Guenter Roeck
@ 2016-03-04 19:37 ` Wim Van Sebroeck
1 sibling, 0 replies; 3+ messages in thread
From: Wim Van Sebroeck @ 2016-03-04 19:37 UTC (permalink / raw)
To: Thierry Reding; +Cc: Guenter Roeck, linux-watchdog, linux-kernel
Hi Thierry,
> From: Thierry Reding <treding@nvidia.com>
>
> The driver uses the atomic_io_modify() function to update registers, but
> that function is only available on 32-bit ARM. Recent changes have added
> ARCH_MVEBU support to 64-bit ARM and hence allowed this driver to build
> on 64-bit ARM where this function isn't available and thereby causing
> allmodconfig builds to break.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9289da313d98..cfec157488b1 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -399,6 +399,7 @@ config DAVINCI_WATCHDOG
> config ORION_WATCHDOG
> tristate "Orion watchdog"
> depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
> + depends on ARM
> select WATCHDOG_CORE
> help
> Say Y here if to include support for the watchdog timer
> --
> 2.7.1
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-04 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-24 14:22 [PATCH] watchdog: orion: Depend on 32-bit ARM Thierry Reding
2016-02-24 15:29 ` Guenter Roeck
2016-03-04 19:37 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox