From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
konrad.wilk@oracle.com, david.vrabel@citrix.com
Cc: xen-devel@lists.xenproject.org, mcgrof@kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH v2] xen/x86: Zero out .bss for PV guests
Date: Wed, 24 Feb 2016 12:48:19 -0500 [thread overview]
Message-ID: <56CDECE3.7020602@oracle.com> (raw)
In-Reply-To: <56CDE7D9.6000209@citrix.com>
On 02/24/2016 12:26 PM, Andrew Cooper wrote:
> On 24/02/16 15:19, Boris Ostrovsky wrote:
>> + /* Clear .bss */
>> + xor REG(ax),REG(ax)
> If we are nitpicking,
>
> This should be xor %eax, %eax even in 64bit. Functionally identical,
> and shorter to encode.
Right, Brian Gerst pointed this out too in another message.
-boris
prev parent reply other threads:[~2016-02-24 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 15:19 [PATCH v2] xen/x86: Zero out .bss for PV guests Boris Ostrovsky
2016-02-24 16:05 ` Brian Gerst
2016-02-24 16:33 ` Boris Ostrovsky
2016-02-24 17:26 ` [Xen-devel] " Andrew Cooper
2016-02-24 17:48 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDECE3.7020602@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox