From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754369AbcBXRsS (ORCPT ); Wed, 24 Feb 2016 12:48:18 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:16570 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbcBXRsQ (ORCPT ); Wed, 24 Feb 2016 12:48:16 -0500 Subject: Re: [Xen-devel] [PATCH v2] xen/x86: Zero out .bss for PV guests To: Andrew Cooper , konrad.wilk@oracle.com, david.vrabel@citrix.com References: <1456327186-27354-1-git-send-email-boris.ostrovsky@oracle.com> <56CDE7D9.6000209@citrix.com> Cc: xen-devel@lists.xenproject.org, mcgrof@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Boris Ostrovsky Message-ID: <56CDECE3.7020602@oracle.com> Date: Wed, 24 Feb 2016 12:48:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <56CDE7D9.6000209@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2016 12:26 PM, Andrew Cooper wrote: > On 24/02/16 15:19, Boris Ostrovsky wrote: >> + /* Clear .bss */ >> + xor REG(ax),REG(ax) > If we are nitpicking, > > This should be xor %eax, %eax even in 64bit. Functionally identical, > and shorter to encode. Right, Brian Gerst pointed this out too in another message. -boris