From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758162AbcBXR5p (ORCPT ); Wed, 24 Feb 2016 12:57:45 -0500 Received: from mail-bn1on0064.outbound.protection.outlook.com ([157.56.110.64]:2944 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752085AbcBXR5m (ORCPT ); Wed, 24 Feb 2016 12:57:42 -0500 X-Greylist: delayed 68094 seconds by postgrey-1.27 at vger.kernel.org; Wed, 24 Feb 2016 12:57:42 EST Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O32CK1-07-2B3-02 X-M-MSG: Subject: Re: [PATCH 1/4] EDAC, MCE, AMD: Enable error decoding of Scalable MCA errors To: Borislav Petkov References: <1455659111-32074-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1455659111-32074-2-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160223123744.GC3673@pd.tnic> <56CCE23D.6080802@amd.com> <20160224112846.GA3888@pd.tnic> CC: , , , , , , , , , , , , , , From: Aravind Gopalakrishnan Message-ID: <56CDEF0F.3010107@amd.com> Date: Wed, 24 Feb 2016 11:57:35 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160224112846.GA3888@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(199003)(479174004)(164054003)(189002)(24454002)(377454003)(87936001)(3846002)(50986999)(23676002)(11100500001)(76176999)(87266999)(54356999)(189998001)(65816999)(110136002)(105586002)(2906002)(5004730100002)(36756003)(93886004)(586003)(4326007)(65956001)(86362001)(47776003)(1220700001)(230700001)(5008740100001)(59896002)(6116002)(101416001)(50466002)(83506001)(92566002)(2950100001)(33656002)(19580395003)(106466001)(77096005)(65806001)(80316001)(1096002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0707;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: b5dc6adf-6df1-4395-a52c-08d33d43fc53 X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0707;2:5Nd46RW7roMpeRBuVVB6v3nTdFK2wSlY2FDixdyYXHVJl1hzRoTE8ksuj9H07zseIl+OdOSlX/b0+9yyXYs7QkwsrEHt7d1OFE8z8KGFQh936/avs3udZQKVy7lR+ldnO+WET1vo7+9FtSWY5TyggsvmZqwDwhEiCyRzgqslbSQTs0gOzG8XOYjWl6R23tMV;3:NH0lvmmd2sucjQOPE9s8KHE2cn+t6kAOGw9MS/tZ6BYLpL6+S4Im2jsNU1c01nBNBMY6OoXQ5EZkFOAw61ZTct0SCbjMID1DYOE90LLbdDvWZtYPT6FLrVDjmKx1HE0Ny8ynadUvT1Tp/EXLKKwri/q8/RMXgogPFgqEH3JF5OV27d5dMJ1gjBp4YhfS4PyMGbpCJGQwVpJ8Tdm9xTiFgU8XQu3372Zun7fUtmSr6zI=;25:rnBpvwpRDz3iMzthZXcoKQI3J6COD6l4H5pl9xDA+RtCCZ46eceok+XqM6+dSD5ih02ZVkUPAGkNLJU0ffs0dTC3dncjuqvADKK2Wd75TXt/0a+pSqYhMKCKynbNecKehwdjCohF6UpMICktw4YRRBm7BZKfRfJtk2ZrYbSsS70vejOOxBhrCJcTluDfJ3VWmVW4tZda2m8m36fT4d7UQDZkZ9aqnic6tkSln+lZPKlY95uSGP+CXVGSn62Wm8QO4+e7NI7NN+e/h7nMYAzN0N+l3T0DZuxyHRCWScQ0cVIgsRi+ERF/x4mNKIn/RGwGt3zkWKc+2SFkpj27Y3D8zg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0707; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0707;20:kKObHLnTeDU3sV4J8nwvnviqiEN5yzTJfgYjF7GDoaM5f5nYYdFEDY9+Lp2VlZBg+D2s4I8r4M/8oCwFlDUrGYyGWvfgL7QP2UaaVQ6dfdTPUTBJHCEzTIaIrPa8BPFVhgRQqKHRtMmH1i/QLPHnPRPnCzhHTzX1xuPBCFkRz93T2Bwxuiori5AkflgyN3DNOMdXglfxUzJW4oCx21B8xjZ+V00PhDKNPe4Rfrr71ljOd53kD+5WRKfoLnYvpmnse+mEBasnb8YOd4jzmth66TcouUYKMerTuZ100EUAM3L+DYlt3GAvKHDSceKbmSNsamvLPnRs7kFtboaHmtsA1waV9JZSYKvaHQuG9jn04SgOtCfMCZVBl7UKbPtWKhqefYXYp7cO5FrTp8SO/wArs044ivZrzsu4/zpWGR7wvV7ZRum5vhIQmEJpmnMF1fO083nz2OnlYVhGvnIOA6HPm2sjKR7NY99u3ZfpGobFbdC3EO1TxeD9nKm5aFlev6tZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13018025)(8121501046)(13023025)(13024025)(13015025)(13017025)(3002001)(10201501046);SRVR:BLUPR12MB0707;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0707; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0707;4:bbpetucgzF9h4x7ltRVd9YrYc3yBwVvgykg6gmXKQlVOqkbFLMDlWKj3IgD9fRGQPtVv3+7w5iJa2TVoSWKjNWh+iivVMFjmsfR6RAkuRHtWA846tagHJmrXTcXr2OkD/sO+XeLhWB2fCgPzT5cg5GhYTDkGo47mLMqBWrUzf9a/2Ji2BtgrRoJVep8HbuYAhdRyuR6ubnylHd88nT2G92cWcTia9gwfuhVfR4Xpa7WxvMl8CvNaYDd01OcAu2a8AkxpBY5rGpUZGT7LopV9LgdXayGDdN9XnsEwHnSDUFS21PwPgTS1uZKRpJMw1YBBHESxLZ2DCVz6lfduF8UHg3Z6p3bC14rPNCBZ4r+p3t+Qb+zklDGduEgwnrdZT/iJikeaPjEHsjkKuYiadjIYN4QLjlXtPUoy25jdBEi80rwETCrGyPuYuaRY1cVuDQDoq4iTPQq6N3jMpcEkzr0bMA== X-Forefront-PRVS: 08626BE3A5 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjEyTUIwNzA3OzIzOnNoaU5aOXlqU1h4dUs0bHJ3UGNUU2xwMURG?= =?utf-8?B?S2JWMkpOQk1naW50Y25UTkF1YWVHTGJCNi9xVWZtQzgrZFlRVXFVcllQbE5F?= =?utf-8?B?M2JvM3VEU2Q1VEhNV1E3VGhKQjZuQnRScHRjaVRrUWpHRjQ2YStEekV3WHhT?= =?utf-8?B?MnpLS2lyYmt6NFJNczltNUl4cTh3WkMxSDc1M3lZM01SS0hNSkdrTllpWi8r?= =?utf-8?B?MitxUXRUR1JQOHM4dWNlYk42SjU5aDRtdXQydmtVSitFR3QwOFE2Z1FJTlJm?= =?utf-8?B?QkxtdjlhR0pDZEVmZlliQ3cvZVVuWmNkL0hjaWJzN09MNEFhcndhaHBibi84?= =?utf-8?B?bk94TG80cEdkd3dZZy9Cd3J6VVE4dTgzeDRSbGdycmdoUnJPcDBmcWRld0ts?= =?utf-8?B?RjlaeWVJdHd4WHNCckYvSFlxOW9ncFdSWk5OblcwR2ptUnluSTJvdzhWbWVq?= =?utf-8?B?L1doWU9FS2Jab2gvaWhLajRsMGZCaUpQTVUrRFBzQkN2YWNGL2lETkhscXNq?= =?utf-8?B?Q29tV0lzazdMUm5rYUc5V3pGVk9uZHVaOHY1SWs0YWNFMi9UaU1SV3FQQjYv?= =?utf-8?B?US9xdEVBTmRJbzliTkluayt1OGNkZkdpSXd5YnMrUlBFZlJrMWVSNk1tWGtG?= =?utf-8?B?akRJdDgzWkh1Z0ttTXUyRUFFK1UyYzZKNDlySy85ajAwVHU4Sk9laktrV2lo?= =?utf-8?B?ODR2eTE3bFM0SEgyUmREeXVnUWFITVovaDN1SGlFM0xMMEhXSGhFZ1plMWl4?= =?utf-8?B?eU1SSUt4cTZkdkthMitOc1IwazNOVDNRd3BsVC9yNFhiUTRsTXlSTmxHTUxZ?= =?utf-8?B?b05DUU1PUGZRaCs4R0QxblA4S08yUHRoQThyMjlJOERWb0djR2d0S3JTeXNz?= =?utf-8?B?cS83QURnbVNMVGJuVjlwT0g0bUVSSkpBYTU1Z3ZOZnlNNXdUUUxOYXExalhl?= =?utf-8?B?SCsxRndKbnk1aEJFTVRLVFdDR1JpdkIrZ25rcnRHTXNSK2VzRjZvVVk5V3hR?= =?utf-8?B?Ui9UVTZ1RjBTbHhFa1B4dGlrUWZ6bG5wTjlQVzhyRGdyTHRjWTFGb2hlKzk1?= =?utf-8?B?Nkc3cFhQb2NyV1djUDJmQ2ZUSm5PbFg5ZU1GYTAyQXlSK3g5TGhzbTZneTVr?= =?utf-8?B?UGFpa0tXR2VIYXlNVXV0NHFiZ0l1NU1ieGJuam9OMzgyN0JsVEtMKzJlUjJz?= =?utf-8?B?TWZPUUFSZmxtT29HVDd1ZEtML2ZxUWlTSTN0SkIzRExQMjZ3UFF6Sk9MSFFm?= =?utf-8?B?ckZHUmc3RFVEemxJbmN1czhqOUcvaUE1OTczSXU5Q2podWxFbmNDT2dBSzJH?= =?utf-8?B?M3lIMjY5Q3N6TEZGeXUwQXM1NVhhNURUSTBGRUVUM1VsRkFOY2dtMWE3QmdC?= =?utf-8?B?MURxN1FKNEdHZmdoZU9EVWRiUitHOWtWdXpEUTRyQ3lhejZ3VXo5dzVabnNw?= =?utf-8?B?aXJkNVNXZmRzY1BnOGRjWWI5YWpGNmRrNnhUTHN0dkdLSVQwbnUrNGo3RkQ2?= =?utf-8?B?c3QwQlBXS3pYTFJxTlpxOVdIRDFWYXlZeEtDei9WODl5VW5uWGhscGhENXVL?= =?utf-8?Q?5GDKyOtvPiazjR21OrZtv10efUuObqopAUEAj+/ZnqBY=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0707;5:JReSBcotnOc4BHmRsJzxCaeiqIdFaHCW6LAljeIiIXs8ztbTxMs4PgbmwwJRLuomph3LbqDUK/9W2NDhNvM4lcNs2Q1tC1HKPkCOjJDEMbOrJd9tJc7M8tGn8lgtP9r/bBwIaXuJ+P9vqn50Q0CS8w==;24:83MzSWUgyJy590piOKmSTe5l57HmYxTGSe4mNikwKvF0dAlimswiwjVRr3ByyJZsaAhQtO6hsPxhAfGvBSjuma+3Ec9FtJy4knfymL38kSo=;20:I3Il+WJWx/TQpm1xq/yR9sJZUADznlcR6yLXwIirfqYt+nWUu0DBLdaq5p5uEhf7I95PsP108Orl5Lvhk/0oB8BGFmXIVCNs2ZPoDTBKssDEJCM2wFlUn6AzJv5sCcrFBKQ0KvXiG5yzb+fGQJmz2ac8uzScXiAX09vLdXc0Jp9lcoF//jL00z8R6wYG08XsFBWKRgzkZY4QBYO9qWtGBdAgGGlXduT/K8JAlCC0V+WHd4/ZBkcVnEf8tVeAUQmH SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2016 17:57:38.2627 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0707 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/2016 5:28 AM, Borislav Petkov wrote: > On Tue, Feb 23, 2016 at 04:50:37PM -0600, Aravind Gopalakrishnan wrote: >> Sorry about that. Looks like this pair is not defined in spelling.txt. So, >> might be worth adding there as well? > Oh geez, we have a spelling.txt! I think we can declare the kernel as > done and go do something else with our lives... Haha:) >> It's the block for programming FUSE registers. > Oh, that's what it is. > > So maybe "fuses block" or "fuses" or ... just the capitalized "FUSE" is > kinda misleading. Asked about this internally. Looks like it might be renamed to "Parameter block". So, I'll use that. >> How about "Unable to gather IP block that threw the error. Therefore cannot >> decode errors further.\n" > Or simply "Invalid IP block specified, error information is unreliable." > and still continue decoding. It might still be recognizable from the > signature, methinks. Hmm. We might be able to decode other bits of MCi_STATUS. Not the XEC which is what we do in this function. So better to return early if we can't figure out which IP block to indict. >> If for some reason the CPUID bit is not set, then we should not assume the >> processor supports the features right? > Is that even remotely possible? If yes, then we should keep the warning, > otherwise it is useless. > Yes, it is possible. Thanks, -Aravind.