From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758524AbcBXSDB (ORCPT ); Wed, 24 Feb 2016 13:03:01 -0500 Received: from mail-by2on0073.outbound.protection.outlook.com ([207.46.100.73]:15925 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758482AbcBXSC5 (ORCPT ); Wed, 24 Feb 2016 13:02:57 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O32CSO-08-CNO-02 X-M-MSG: Subject: Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address To: Borislav Petkov References: <1455659111-32074-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1455659111-32074-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160223123907.GD3673@pd.tnic> <56CCE3A6.3020406@amd.com> <20160224113315.GB3888@pd.tnic> CC: , , , , , , , , , , , , , , From: Aravind Gopalakrishnan Message-ID: <56CDF049.4080502@amd.com> Date: Wed, 24 Feb 2016 12:02:49 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160224113315.GB3888@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(377454003)(24454002)(199003)(164054003)(479174004)(86362001)(83506001)(92566002)(6116002)(101416001)(50466002)(77096005)(19580395003)(80316001)(19580405001)(106466001)(15975445007)(2950100001)(65806001)(33656002)(87266999)(76176999)(65816999)(54356999)(230700001)(65956001)(4326007)(105586002)(189998001)(11100500001)(110136002)(50986999)(23676002)(87936001)(3846002)(59896002)(1220700001)(47776003)(1096002)(2906002)(5004730100002)(586003)(5008740100001)(93886004)(36756003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0854;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 61fdcafd-d4b7-41c3-f706-08d33d44b7fa X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;2:9khTy//I0My4JzuoNxQoq7YO4l60MHzvo0Cy1H35q7nmsKryxJYqpNzFC3NNjNVx1N5GgvIfBJfmDJPclY33J5JnPXmy6/ws63VoPW7vCDjI9sWybtNx9DavIbxuNj2QSNLuKx1OAAjvAF5TYOitwcHTli62K66zWVNu5GLGmVKtLo6duSmcvMBywFKOYuOb;3:D8X7yNfXKeHvqbxMQykSVUbmFhoGTsO/P0kuzDjzJJOfQngUbNfPL8Yb7onZh+ExV8VSsGR4qpdRZAP5EpMm9dDsD2i1HIHmByT/rLTsrTYnbALYVfOEka9TOx+FulU8SeDT2x8TSW8o12VsclwvBn5dnkvESpGWEJZ8iz6ddDnR63lbPE8Z4doOZtsJc7vTJWbkMI9zRpidiFEo4ZiVsdP3DfFly+qi1tSklReDbXA=;25:A4cWuFfYBztbtZydsjOprfs4950E1SBqwmBsgnrvGbOgr2JNDxZhfA0uebwhOXWd3rQEsFTTeDW9zKBFGjLFAbFBC1ESgJIlt9kuayYwwdrq+49XhjWAI9kQqTGkyRbUQ1gn62O5XA3gUrq68dd4pPgjU/HPEv8Z7PuXwx3UXW6WKlX/vk4qGWpyV2l9eNZhzuJ0rgvRV0bY+amf9E3r6o2H9PxPTGLipRjMmUysKcPcLwV1Q5xSV1tWtnmExI8je+LlojuX3sDXy7EsAl3LNBJqGTV0Q1TArqIqb+pi+uMOgjk0lzlr6Fsc0lXg0ih7fjBAu3aSkDnCAf+lzvhaCw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0854; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;20:iV9Jn8i0M1r+bdrIV2c+5oKm9ygmpgyXf4tT5+c5+WpoRClMNaJr9njCNheG5ECdQVLIahyI38je0ZvLXlBz5MmsSVcmqaAbNS/21Q7BWS+C42euOlD0JUSN1I/jiZfX5KID0N3PY8+gMsA7uppR7Zt7iQ/vSXTwPYXEJd/R1nIauTWTb/dcKjDPvP+TM7RNrPRFL/Jbw2X767klpuPf1bd9HOgdAPQE8w64wRxm2ZRvZr22fI1QH6KeaJ29L2FB86m2w3xJTXYBCRP8daWWfyE1PAxQb/er75tlDXbK3RyxIzxf8r75YOzP4O2NTsIc39qfFFX3jBzjcNk1O4Bqfj3ztq77CKVM+pNtO/CbMCC/LhVSIRwk174GyvC5JVAhEMbgBpp4wYyXlYcmGT+zZzfQeWGQalNeM0DMXdE7BTZ4aIZgFE1dkGDXXT5zJ0TSl+iI1nQJF9dG69f7FP2o4Oi8/y4OJkq2cvkKuOngeHG3smQ7I57AF9E7ESl7MRPO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13018025)(8121501046)(13024025)(13017025)(13023025)(13015025)(3002001)(10201501046);SRVR:CY1PR12MB0854;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0854; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;4:feGfIGcWZL1h9jBmFVo42dq+8svlojhjL1B99ub/B3IiEJrCBZ5z91GvqeaBLAGVF5Isk/cuM1K20nxD5LQdN23m749CmGwpVdh5qNfOXlj84hOimi2mP+8RToCggl7GRfj4vLiwQoRlGXhFiF9Nvd0CCL3qd56s1MlottneaQbo5LPOSMV7F3N7v2qYY6dBo9oNn9mR0UnoTm7oGY5bHM3iYzayZsklXrPuFJL1/QBoiCEX76gXy5+0Pa2nCPO/kcb0axnZ+Wijp3cp8D84iTlsWYi0+hZLRWWOw+AZipgIHx9Zj5i69T4U+FtvRDissSNxY8m7PxpUdvKg1T1V0N6X2mu/PfPyzNEwpydk/wdwMKpNm/PSQ1sGx5LgJJ1Fhi7gvbJWd0CVPrTlSiMfPEI7ZrH2pVlLUg/5flx5mLMe+dPYaaXTuZXeq2eMTj+lLxtR9WQSjv+b6jBhHVSTvw== X-Forefront-PRVS: 08626BE3A5 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwODU0OzIzOmxJNGdOUG83RG9Jem02eStIbGF1Nkl6UFNl?= =?utf-8?B?TkkwUGplV0hQTjUzby84Tnd1anMxTFZOcFo4NmtYNmVNZ2YwbU9UdjRsWGZr?= =?utf-8?B?Qno0SDNScVNKUEw0MnU4TnNRMmNlS1dRNU0zanp6UzQxbGwvV3g4ZFJ1cEpM?= =?utf-8?B?a0ord2VFemFoUlZOcG1RRUpWT2JYZjhoaDc0UThoMTdqVElvMXdBVUVDRDVW?= =?utf-8?B?UzRVaU5XcDBvaWpnUHFRQXpRL2tOdFIvNXkydU5aZU9adHduM3I4REovVXV4?= =?utf-8?B?c09DQk1VV0RvQ01zZkJWdnZhNi9rZ2JXWlpIVytxblVOaytFckZ1MjlVVWM4?= =?utf-8?B?YkdCZ0F6TGFYTW9VRmRCTjdKUWZreXB5ZTk1aG9Ydk9MajJZUmlnRzZWdHVF?= =?utf-8?B?NHZVWHFFVDdhSzV6MklZek96UkFpTXAwVHUrUVpTMSt4Z2dYSmtEckNaR3ZG?= =?utf-8?B?eVMybE1yd0dObGw0ZDI1RnJEZTZNQ3RVMzRNYWwrK2l0M1N3dTV4dzhDT282?= =?utf-8?B?WDE4ZDhTVXdkNDR2bUhFZ3AyTlVEYmlIRHU5S0JWNmw3K0xkcTloVlNkaTBj?= =?utf-8?B?elhsbnY1bEZPMWtwQ05kdUgwdWxSUUUvWEI1Z2dSSGFUaGdTdUc3blE4ZUhw?= =?utf-8?B?R252MmpGMkNRM1RFeS9iSDdZclBLcjVNd21MdGdqYkhmSFRqV1BYYzJmWGtQ?= =?utf-8?B?d05ydlpEOVFhUlllNzBYNFZ0OWN6Q0s1Qk1YSERzanhac2tQMUpEZmN4OTd6?= =?utf-8?B?OGEzMjZyd3pqdzlvTUpoWHFoQ1NCeitGTmRQc09QM25wSWRqM1p5NU8rdXJE?= =?utf-8?B?S25BeHB6S2laR1QyWjdxemt6cFNPZ0pGZ2FERU41SXcwUGhrNzlVV2dWZEdt?= =?utf-8?B?N0drUXUyelRvaGpoMFE5c1JlcG5yREw0MWpid0FFOGxQNFBEaXJEamJpd2ha?= =?utf-8?B?c3pZSHlIcVBuRmpKdWIvdlpjdG1SLzlFQXRmVktsWWdJSWVENGVzaUYxKzZp?= =?utf-8?B?Y25WNmprTGcxYis3UUVuWUFsQVlIV0x5TlA5VVAxNmJTLzY5d0NlZzB6Q3JP?= =?utf-8?B?ZXN5cmtyZmlSMUJ1SUhuN21kekhKTGtmLzA5NGtDbW5aeGIyUFF4N2RoK2xt?= =?utf-8?B?WmZ0SkxmNEJzVmtBS0N4bEJYYm9YZFAyVnpFcDk1cGQ1SEczcS9MMGxZZDhl?= =?utf-8?B?bGs3cTlQalArQ1A1UHZRbjdsSFhzY1hiY2J2Tnl3Uk1pSXBPUENHVmJCa1dF?= =?utf-8?B?TWF0N2FKRHdWOUlNb2R0NkV2L0g3Y1h5S1Q4ZDlqa0hIZHlXUXRZdTFUWFUz?= =?utf-8?B?Mk1JTXBacUxZb01VVlZETTlFQzN3UDBweVJnbU5ZUlhZWWxhZHhMVmhkZG1u?= =?utf-8?B?Z1NDVFprb0N3Z3kzSnZWR21XazBhSzBaOVNxV2E5dTNvQjdhSzNKT2IvckRF?= =?utf-8?B?Tm4rUHZNb05vaXhpODhJR1R5Nk5ZZUFWQ3Jjcm5mZFFPVzdRUm5NYnM2d2V5?= =?utf-8?B?QkZPQjRCTDhEU1lIMWdscXNXeUdseEE0TTd5aldwbGFKeUJRdWs2bVNvN2N5?= =?utf-8?B?L3VWSVd3NUJCaXoya0FzTEE2N3c3d3B6T3NrSk9ONlJReXdRMEMraU9DeGtX?= =?utf-8?B?MHVJZlN2MWNDYnQzSzE4ZU0vNEk0QUJDeEE4OExEdTgrQkxkaUFRWG9pMHFj?= =?utf-8?Q?JorKFdLGraNbSteRhk=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0854;5:fEIEjUOw2S5p1ejRbp0u6JLUBI9T33zE+P5N2wXNyZdLmIcfXJba3GEkw4ZHMDg5cCrx9EUc6aQJKQ+GfwFuZSOlN4ulN2f2tAqYJONzFvNTVVf5Qf1P7oLB2vjM3nak/F7nhK7ivO2a0hC6LAN3UA==;24:UEzRxR3d5SJ5kNhZTs5zHvEOBJFaiKo0kJGtOyoYU2sgGnuc0GT3o7dAkhVzEGsBVOAKvfzWty70D0+SkJ1ucLXRxD68kxLUJDET6uMMzw4=;20:ST05JG28vtJriqGwpX/7uUwhw4Zrq91vmHf0/3//xbaGhDNQP4bH+o5cRFb8WJzkEXCD7ZRAsmDIU2HXTX8APoqdHIjKP8PiQv+4ojfr98TyS2/0RI/kBnKj2P0GcoyfrBxEaNRudLn74TnLdsKgU5kbL/WdVUrFxn4ZjvzUBDypew6lVJAFq+yDgSG6cEPui50xLMyLbqYvjsO/+x6xczR7WvkCAbdqdK8c9tS5zL+JvAJm07q2LTL2EkOc7hNe SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2016 18:02:53.2026 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0854 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/2016 5:33 AM, Borislav Petkov wrote: > On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote: >> I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well. >> So might be better to retain it here. > Actually, I'm thinking, these all are - even if used in multiple files > - all MCE-specific and therefore used in MCE/RAS-specific code. So they > all should go into mce.h. Everything RAS includes that header so they're > perfectly fine there... Hmm. We introduced MSR_AMD64_SMCA_MCx_CONFIG in this patch- https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e6c8f1873be8a14c7e44202df1f7e6ea61bf3352 Should I change that as well and move it to mce.h? >> (It comes up to 81 chars, but will ignore checkpatch in this case..) > The 80-cols rule is not a hard one. Here's some food for thought: > > https://lkml.kernel.org/r/20160219095132.GA9681@gmail.com > Got it. Thanks, -Aravind.