From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758607AbcBXSJW (ORCPT ); Wed, 24 Feb 2016 13:09:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52963 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758597AbcBXSJT (ORCPT ); Wed, 24 Feb 2016 13:09:19 -0500 Subject: Re: [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing To: Paolo Bonzini , Laura Abbott , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton References: <1455561864-4217-1-git-send-email-labbott@fedoraproject.org> <1455561864-4217-2-git-send-email-labbott@fedoraproject.org> <56CDBCAB.9040001@redhat.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, Kees Cook From: Laura Abbott Message-ID: <56CDF1CC.6070903@redhat.com> Date: Wed, 24 Feb 2016 10:09:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56CDBCAB.9040001@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/24/2016 06:22 AM, Paolo Bonzini wrote: > > > On 15/02/2016 19:44, Laura Abbott wrote: >> -static inline struct kmem_cache_node *free_debug_processing( >> +static inline int free_debug_processing( >> struct kmem_cache *s, struct page *page, >> void *head, void *tail, int bulk_cnt, >> unsigned long addr, unsigned long *flags) { return NULL; } > > I think this has a leftover flags argument. > > Paolo > Yes, I believe Andrew folded in a patch to the mm tree. Thanks, Laura >> @@ -2648,8 +2646,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page, >> stat(s, FREE_SLOWPATH); >> >> if (kmem_cache_debug(s) && >> - !(n = free_debug_processing(s, page, head, tail, cnt, >> - addr, &flags))) >> + !free_debug_processing(s, page, head, tail, cnt, addr))