From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759149AbcBYAaF (ORCPT ); Wed, 24 Feb 2016 19:30:05 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34220 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758803AbcBYAaC (ORCPT ); Wed, 24 Feb 2016 19:30:02 -0500 Subject: Re: commit 271e1b86e691 is breaking DMA uart on SoCFPGA To: Bartlomiej Zolnierkiewicz References: <56BBB201.7060004@opensource.altera.com> <56CC775E.1020203@opensource.altera.com> <56CD4757.4080501@gmail.com> <4702693.ayGVQyLr2V@amdc1976> Cc: Dinh Nguyen , Alexander Kochetkov , Vinod Koul , shawn.lin@rockchips.com, Addy Ke , Boojin Kim , dmaengine@vger.kernel.org, olof Johansson , "linux-kernel@vger.kernel.org" From: Caesar Wang Message-ID: <56CE4B05.5090906@gmail.com> Date: Thu, 25 Feb 2016 08:29:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <4702693.ayGVQyLr2V@amdc1976> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016年02月24日 21:24, Bartlomiej Zolnierkiewicz 写道: > Hi, > > On Wednesday, February 24, 2016 02:01:59 PM Caesar Wang wrote: >> Hi, >> >> Thanks Dinh & Alexander for the intergration testing. >> >> --- >> >> @Dinh, >> >> Can you test it again with the patch[0]? >> >> patch[0]: >> https://patchwork.kernel.org/patch/8398511/ > This fixes the problem for me (tested on Samsung Exynos4412 SoC > based Trats2 board). > > You may add: > > Tested-by: Bartlomiej Zolnierkiewicz Thanks Bartlomiej for sharing the test result.:-) - Caesar > > to your patch. > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > >> - >> Caesar >> 在 2016年02月23日 23:14, Dinh Nguyen 写道: >>> Hi, >>> >>> Sorry that I couldn't get to this sooner. >>> >>> On 02/18/2016 10:07 AM, Alexander Kochetkov wrote: >>>> Hello! >>>> >>>> Bartlomiej, could you please tell what uart driver is used on Samsung >>>> Exynos4412? >>>> Dinh, could you please tell what uart driver is used on SoCFPGA? >>>> >>> SoCFPGA is using the 8250_dw.c uart driver. >>> >>>> Could you make two test? >>>> >>>> 1) Checkout tree at commit 848e9776fee4 "dmaengine: pl330: support >>>> burst mode for >>>> dev-to-mem and mem-to-dev transmit", make it buildable and see is it >>>> works. In order to make in buildable remove bursts argument from the >>>> line: >>>> >>>> if (*bursts == 1) >>>> - return _bursts(pl330, dry_run, buf, pxs, 1); >>>> + return _bursts(dry_run, buf, pxs, 1); >>>> >>> This case still fails for me. >>> >>>> 2) Checkout next-20160211 kernel tree and set src_maxburst and >>>> dst_maxburst to 1 inside UART driver to see is it works? >>>> >>> This case works and the UART is able to operate in DMA mode. >>> >>> Dinh > -- Thanks, Caesar