From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Olof Johansson <olof@lixom.net>
Cc: Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@kernel.org>,
arm@kernel.org, Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Pankaj Dubey <pankaj.dubey@samsung.com>,
Pavel Fedin <p.fedin@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: Re: [GIT PULL 3/7] drivers: soc: EXYNOS drivers for v4.6
Date: Thu, 25 Feb 2016 09:43:00 +0900 [thread overview]
Message-ID: <56CE4E14.2050701@samsung.com> (raw)
In-Reply-To: <20160224222254.GT10126@localhost>
On 25.02.2016 07:22, Olof Johansson wrote:
> On Mon, Feb 15, 2016 at 09:34:02AM +0900, Krzysztof Kozlowski wrote:
>> Hi Arnd, Kevin and Olof,
>>
>> This finally moves SROM controller and PMU code to separate
>> driver under drivers/soc/samsung.
>>
>> Kind regards,
>> Krzysztof
>>
>>
>> The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d:
>>
>> Linux 4.5-rc1 (2016-01-24 13:06:47 -0800)
>>
>> are available in the git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-soc-srom-pmu-4.6
>>
>> for you to fetch changes up to 74a6659e8bf193066ba6bf365de66baa897aebb1:
>>
>> drivers: soc: Add support for Exynos PMU driver (2016-01-25 10:46:59 +0900)
>>
>> ----------------------------------------------------------------
>> A set of changes adding new drivers under drivers/soc/samsung:
>>
>> 1. Split code for handling SROM registers out of arm/mach-exynos
>> in to separate SROM controller driver under drivers/soc/samsung.
>> The driver will save and restore SROM registers during Suspend
>> to RAM.
>>
>> 2. Add to this SROM controller driver support for bank configuration
>> used by child devices. This allows usage of SMSC9115 Ethernet chip
>> on SMDK5410 (Exynos5410) directly connected to SROM controller.
>
> Hi,
>
> OMAP has GPMC drivers under drivers/memory. I wonder if SROM should go there
> too, since it's a quite similar bus.
I wish I get this feedback before, when we were discussing the SROM
patches. :/
Indeed this sounds reasonable. On some boards the omap-gpmc is used for
the same purpose: interfacing to smsc,lan9115 (like on SMDK5410).
> Feel free to respin this without SROM now, so we can get the other pieces in
> sooner and then revisit the SROM asyncronously. That'll remove the dependencies
> on DT as well.
Okay, I'll rebase all drivers/soc branches and respin the pull request
so PMU driver and other stuff could go in.
BTW, just in case, although PMU stands for "Power Management Unit" I
don't think it should be placed under drivers/power because it is not a
avs/charger/battery/reset driver. Existing power-related drivers are
under driver/soc (bcm, dove, tegra).
Re-work of SROM drivers could be started on top of it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-02-25 0:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 0:33 [GIT PULL 0/7] ARM: EXYNOS: Pull request for v4.6 Krzysztof Kozlowski
2016-02-15 0:34 ` [GIT PULL 1/7] ARM: EXYNOS: Non-critical fixes " Krzysztof Kozlowski
2016-02-24 22:18 ` Olof Johansson
2016-02-15 0:34 ` [GIT PULL 2/7] ARM: dts: Exynos DT dependency " Krzysztof Kozlowski
2016-02-24 22:23 ` Olof Johansson
2016-02-25 0:13 ` Krzysztof Kozlowski
2016-02-15 0:34 ` [GIT PULL 3/7] drivers: soc: EXYNOS drivers " Krzysztof Kozlowski
2016-02-24 22:22 ` Olof Johansson
2016-02-25 0:43 ` Krzysztof Kozlowski [this message]
2016-02-25 1:35 ` Olof Johansson
2016-02-25 4:19 ` pankaj.dubey
2016-02-25 4:50 ` Krzysztof Kozlowski
2016-02-15 0:34 ` [GIT PULL 4/7] ARM: EXYNOS: mach/soc changes " Krzysztof Kozlowski
2016-02-24 22:25 ` Olof Johansson
2016-02-15 0:34 ` [GIT PULL 5/7] ARM: EXYNOS: Driver " Krzysztof Kozlowski
2016-02-24 22:29 ` Olof Johansson
2016-02-15 0:34 ` [GIT PULL 6/7] ARM: dts: Exynos stuff " Krzysztof Kozlowski
2016-02-24 22:31 ` Olof Johansson
2016-02-15 0:34 ` [GIT PULL 7/7] ARM: EXYNOS: Defconfig changes " Krzysztof Kozlowski
2016-02-24 22:33 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CE4E14.2050701@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=p.fedin@samsung.com \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).