From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758000AbcBYBKL (ORCPT ); Wed, 24 Feb 2016 20:10:11 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33451 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429AbcBYBKJ (ORCPT ); Wed, 24 Feb 2016 20:10:09 -0500 Subject: Re: [PATCH 09/12] powerpc/ftrace: Use generic ftrace_modify_all_code() To: Michael Ellerman , linuxppc-dev@ozlabs.org References: <1456324115-21144-1-git-send-email-mpe@ellerman.id.au> <1456324115-21144-9-git-send-email-mpe@ellerman.id.au> Cc: duwe@lst.de, linux-kernel@vger.kernel.org, rostedt@goodmis.org, kamalesh@linux.vnet.ibm.com, pmladek@suse.com, jeyu@redhat.com, jkosina@suse.cz, live-patching@vger.kernel.org, mbenes@suse.cz From: Balbir Singh Message-ID: <56CE5469.6050804@gmail.com> Date: Thu, 25 Feb 2016 12:10:01 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1456324115-21144-9-git-send-email-mpe@ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/02/16 01:28, Michael Ellerman wrote: > From: Torsten Duwe > > Convert powerpc's arch_ftrace_update_code() from its own version to use > the generic default functionality (without stop_machine -- our > instructions are properly aligned and the replacements atomic). > > With this we gain error checking and the much-needed function_trace_op > handling. > > Signed-off-by: Torsten Duwe > Signed-off-by: Michael Ellerman > --- > arch/powerpc/kernel/ftrace.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c > index c6408a399ac6..56e5bd53c323 100644 > --- a/arch/powerpc/kernel/ftrace.c > +++ b/arch/powerpc/kernel/ftrace.c > @@ -527,20 +527,13 @@ void ftrace_replace_code(int enable) > } > } > > +/* > + * Use the default ftrace_modify_all_code, but without > + * stop_machine(). > + */ > void arch_ftrace_update_code(int command) > { > - if (command & FTRACE_UPDATE_CALLS) > - ftrace_replace_code(1); > - else if (command & FTRACE_DISABLE_CALLS) > - ftrace_replace_code(0); > - > - if (command & FTRACE_UPDATE_TRACE_FUNC) > - ftrace_update_ftrace_func(ftrace_trace_function); > - > - if (command & FTRACE_START_FUNC_RET) > - ftrace_enable_ftrace_graph_caller(); > - else if (command & FTRACE_STOP_FUNC_RET) > - ftrace_disable_ftrace_graph_caller(); > + ftrace_modify_all_code(command); > } > > int __init ftrace_dyn_arch_init(void) Reviewed-by: Balbir Singh Balbir