From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758437AbcBYBNZ (ORCPT ); Wed, 24 Feb 2016 20:13:25 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:35557 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbcBYBNY (ORCPT ); Wed, 24 Feb 2016 20:13:24 -0500 Subject: Re: [PATCH 12/12] powerpc/ftrace: Disable profiling for some files To: Michael Ellerman , linuxppc-dev@ozlabs.org References: <1456324115-21144-1-git-send-email-mpe@ellerman.id.au> <1456324115-21144-12-git-send-email-mpe@ellerman.id.au> Cc: duwe@lst.de, linux-kernel@vger.kernel.org, rostedt@goodmis.org, kamalesh@linux.vnet.ibm.com, pmladek@suse.com, jeyu@redhat.com, jkosina@suse.cz, live-patching@vger.kernel.org, mbenes@suse.cz From: Balbir Singh Message-ID: <56CE552D.3070606@gmail.com> Date: Thu, 25 Feb 2016 12:13:17 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1456324115-21144-12-git-send-email-mpe@ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/02/16 01:28, Michael Ellerman wrote: > From: Torsten Duwe > > Using -mprofile-kernel on early boot code not only confuses the > checker but is also useless, as the infrastructure is not yet in > place. Proceed like with -pg (remove it from CFLAGS), equally with > time.o, ftrace and its helper files. > > * arch/powerpc/kernel/Makefile, > arch/powerpc/lib/Makefile: > - remove -mprofile-kernel from low level, boot code and > code-patching objects' CFLAGS. > > Signed-off-by: Torsten Duwe > Signed-off-by: Michael Ellerman > --- > arch/powerpc/kernel/Makefile | 12 ++++++------ > arch/powerpc/lib/Makefile | 4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile > index 794f22adf99d..44667fde7ae4 100644 > --- a/arch/powerpc/kernel/Makefile > +++ b/arch/powerpc/kernel/Makefile > @@ -16,14 +16,14 @@ endif > > ifdef CONFIG_FUNCTION_TRACER > # Do not trace early boot code > -CFLAGS_REMOVE_cputable.o = -pg -mno-sched-epilog > -CFLAGS_REMOVE_prom_init.o = -pg -mno-sched-epilog > -CFLAGS_REMOVE_btext.o = -pg -mno-sched-epilog > -CFLAGS_REMOVE_prom.o = -pg -mno-sched-epilog > +CFLAGS_REMOVE_cputable.o = -pg -mno-sched-epilog -mprofile-kernel > +CFLAGS_REMOVE_prom_init.o = -pg -mno-sched-epilog -mprofile-kernel > +CFLAGS_REMOVE_btext.o = -pg -mno-sched-epilog -mprofile-kernel > +CFLAGS_REMOVE_prom.o = -pg -mno-sched-epilog -mprofile-kernel > # do not trace tracer code > -CFLAGS_REMOVE_ftrace.o = -pg -mno-sched-epilog > +CFLAGS_REMOVE_ftrace.o = -pg -mno-sched-epilog -mprofile-kernel > # timers used by tracing > -CFLAGS_REMOVE_time.o = -pg -mno-sched-epilog > +CFLAGS_REMOVE_time.o = -pg -mno-sched-epilog -mprofile-kernel > endif > > obj-y := cputable.o ptrace.o syscalls.o \ > diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile > index a47e14277fd8..98e22b2d7bec 100644 > --- a/arch/powerpc/lib/Makefile > +++ b/arch/powerpc/lib/Makefile > @@ -6,8 +6,8 @@ subdir-ccflags-$(CONFIG_PPC_WERROR) := -Werror > > ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC) > > -CFLAGS_REMOVE_code-patching.o = -pg > -CFLAGS_REMOVE_feature-fixups.o = -pg > +CFLAGS_REMOVE_code-patching.o = -pg -mprofile-kernel > +CFLAGS_REMOVE_feature-fixups.o = -pg -mprofile-kernel > > obj-y += string.o alloc.o crtsavres.o ppc_ksyms.o code-patching.o \ > feature-fixups.o Reviewed-by: Balbir Singh